Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hdfs: init at 2.5.8 #137713

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

samuela
Copy link
Member

@samuela samuela commented Sep 14, 2021

Motivation for this change

Add the hdfs python package.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@samuela
Copy link
Member Author

samuela commented Sep 14, 2021

Update: CI is currently failing because I forgot this depends on #137685. Once that lands, I'll rebase this and we should be good to go.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add pythonImportsCheck as additional safe-guard?

@samuela
Copy link
Member Author

samuela commented Sep 14, 2021

Could you add pythonImportsCheck as additional safe-guard?

Done in efe93cf

@samuela
Copy link
Member Author

samuela commented Sep 23, 2021

I rebased and squashed on the latest master now that #137685 has been merged. I think this should be ready to go now!

@smancill
Copy link
Contributor

Fails to build on Darwin because of #137678:

 nixpkgs-review pr 137713
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/137713/head:refs/nixpkgs-review/1
remote: Enumerating objects: 9, done.
remote: Counting objects: 100% (6/6), done.
remote: Total 9 (delta 5), reused 5 (delta 5), pack-reused 3
Unpacking objects: 100% (9/9), 46.71 KiB | 810.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 + 2dfffe79b2e...a4d96cd808f master                -> refs/nixpkgs-review/0  (forced update)
 + b93b2a2c21f...e3ae16550b1 refs/pull/137713/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /Users/smancill/.cache/nixpkgs-review/pr-137713/nixpkgs a4d96cd808f13d924988938ecf9a46b2a2787fa3
Preparing worktree (detached HEAD a4d96cd808f)
Updating files: 100% (28104/28104), done.
HEAD is now at a4d96cd808f Merge pull request #139674 from mweinelt/python/clevercsv
$ nix-env --option system x86_64-darwin -f /Users/smancill/.cache/nixpkgs-review/pr-137713/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit --no-ff e3ae16550b1a49fba50fea1a225637217f8b5a35
Auto-merging pkgs/top-level/python-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix-env --option system x86_64-darwin -f /Users/smancill/.cache/nixpkgs-review/pr-137713/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python38Packages.hdfs (init at 2.5.8) python39Packages.hdfs (init at 2.5.8)

$ nix --experimental-features nix-command build --no-link --keep-going -f /Users/smancill/.cache/nixpkgs-review/pr-137713/build.nix
error: builder for '/nix/store/ib9vjgbxjah5668y0wbx9d7v3mspjzx5-python3.8-beautifulsoup4-4.10.0.drv' failed with exit code 1;
       last 10 log lines:
       >         soup = self.soup(markup)
       > >       self.assertEqual('Sacr\xe9 bleu!', soup.root.string)
       > E       AttributeError: 'NoneType' object has no attribute 'string'
       >
       > bs4/testing.py:1002: AttributeError
       > =========================== short test summary info ============================
       > FAILED bs4/tests/test_lxml.py::LXMLTreeBuilderSmokeTest::test_real_hebrew_document
       > FAILED bs4/tests/test_lxml.py::LXMLTreeBuilderSmokeTest::test_smart_quotes_converted_on_the_way_in
       > FAILED bs4/tests/test_lxml.py::LXMLXMLTreeBuilderSmokeTest::test_can_parse_unicode_document
       > ======================== 3 failed, 514 passed in 1.97s =========================
       For full logs, run 'nix log /nix/store/ib9vjgbxjah5668y0wbx9d7v3mspjzx5-python3.8-beautifulsoup4-4.10.0.drv'.
error: 1 dependencies of derivation '/nix/store/gfy98yssd5q9k31acbd6szmn6j3457qp-python3.8-pandas-1.3.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qa29p8xzl0rg7fjb2k8jbb4blkq29bgx-python3.8-fastavro-1.4.4.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vi21p4zb57xgjc16ifq32z6xliih6ryk-python3.8-hdfs-2.5.8.drv' failed to build
error: builder for '/nix/store/vq9nm18v7qp5mjpg1487qnjpwq4pmqsm-python3.9-beautifulsoup4-4.10.0.drv' failed with exit code 1;
       last 10 log lines:
       >         soup = self.soup(markup)
       > >       self.assertEqual('Sacr\xe9 bleu!', soup.root.string)
       > E       AttributeError: 'NoneType' object has no attribute 'string'
       >
       > bs4/testing.py:1002: AttributeError
       > =========================== short test summary info ============================
       > FAILED bs4/tests/test_lxml.py::LXMLTreeBuilderSmokeTest::test_real_hebrew_document
       > FAILED bs4/tests/test_lxml.py::LXMLTreeBuilderSmokeTest::test_smart_quotes_converted_on_the_way_in
       > FAILED bs4/tests/test_lxml.py::LXMLXMLTreeBuilderSmokeTest::test_can_parse_unicode_document
       > ======================== 3 failed, 514 passed in 2.83s =========================
       For full logs, run 'nix log /nix/store/vq9nm18v7qp5mjpg1487qnjpwq4pmqsm-python3.9-beautifulsoup4-4.10.0.drv'.
error: 1 dependencies of derivation '/nix/store/j7g7l6q0phgj59jza1csaqv1as1pzl53-python3.9-pandas-1.3.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/rwry5hxb034skjn7xqzqp3a7w6n6d29d-python3.9-fastavro-1.4.4.drv' failed to build
error: 1 dependencies of derivation '/nix/store/dwzg5i8f7jy14cq6y51ixj61p8lyzxym-python3.9-hdfs-2.5.8.drv' failed to build
error: 2 dependencies of derivation '/nix/store/2h41fl995n06mglijfp4hndb3lcg22nj-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/137713

2 packages failed to build:
python38Packages.hdfs python39Packages.hdfs

error: build log of '/nix/store/vi21p4zb57xgjc16ifq32z6xliih6ryk-python3.8-hdfs-2.5.8.drv' is not available
error: build log of '/nix/store/8ymz34hb8ckfc3v05zlwq78akvamrc3y-python3.8-hdfs-2.5.8' is not available
error: build log of '/nix/store/dwzg5i8f7jy14cq6y51ixj61p8lyzxym-python3.9-hdfs-2.5.8.drv' is not available
error: build log of '/nix/store/05957yw0fi56fpwgi842bj5sfgzlbsz4-python3.9-hdfs-2.5.8' is not available

@SuperSandro2000
Copy link
Member

@ofborg eval
@ofborg build python39Packages.hdfs

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 16, 2021
@SuperSandro2000 SuperSandro2000 merged commit fc0da5e into NixOS:master Nov 17, 2021
@samuela samuela deleted the samuela/hdfs branch November 17, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants