Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fastavro: init at 1.4.4 #137685

Merged
merged 1 commit into from
Sep 22, 2021
Merged

python3Packages.fastavro: init at 1.4.4 #137685

merged 1 commit into from
Sep 22, 2021

Conversation

samuela
Copy link
Member

@samuela samuela commented Sep 13, 2021

Motivation for this change

Add the fastavro package.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@samuela samuela mentioned this pull request Sep 14, 2021
Merged
12 tasks
fabaff
fabaff reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pythonImportsCheck.

@risicle
Copy link
Contributor

risicle commented Sep 14, 2021

Curious failure for me on python 3.8:

builder for '/nix/store/cwcxigjmqxgrni8i3i3q5w8sfw2xlkp7-python3.8-fastavro-1.4.4.drv' failed with exit code 1; last 10 log lines:
    File "/nix/store/66p7i56lg3zzp7nj6g0fywb704ihp4iy-python3-3.8.11/lib/python3.8/contextlib.py", line 7, in <module>
      from types import MethodType
  ImportError: cannot import name 'MethodType' from partially initialized module 'types' (most likely due to a circular import) (/build/source/fastavro/types.py)
  =========================== short test summary info ============================
  FAILED tests/test_main_cli.py::test_cli_record_output - subprocess.CalledProc...
  FAILED tests/test_main_cli.py::test_cli_stream_input - subprocess.CalledProce...
  FAILED tests/test_main_cli.py::test_cli_arg_metadata - subprocess.CalledProce...
  FAILED tests/test_main_cli.py::test_cli_arg_schema - subprocess.CalledProcess...
  FAILED tests/test_main_cli.py::test_cli_arg_codecs - subprocess.CalledProcess...
  ============ 5 failed, 573 passed, 6 skipped, 1 deselected in 4.30s ============

@risicle
Copy link
Contributor

risicle commented Sep 14, 2021

Yeah test_main_cli.py is doing some really weird stuff - calling the cli from the source directory, not the installed version.

@samuela
Copy link
Member Author

samuela commented Sep 14, 2021

Please add pythonImportsCheck.

Done in 11921c0

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 14, 2021
@samuela
Copy link
Member Author

samuela commented Sep 14, 2021

Yeah test_main_cli.py is doing some really weird stuff - calling the cli from the source directory, not the installed version.

Very weird indeed... I disabled that test file in 1cbd5cf and opened fastavro/fastavro#558 upstream.

@fabaff
Copy link
Member

fabaff commented Sep 18, 2021

Can you please squash the commit? Thanks.

@samuela
Copy link
Member Author

samuela commented Sep 18, 2021

Can you please squash the commit? Thanks.

Sure, done in 501cff7

@risicle risicle merged commit 18134ae into NixOS:master Sep 22, 2021
@samuela samuela deleted the samuela/fastavro branch September 22, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuela @risicle @fabaff @bobby285271