Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buf: 0.43.2 -> 0.44.0 #130091

Merged
merged 1 commit into from
Jul 13, 2021
Merged

buf: 0.43.2 -> 0.44.0 #130091

merged 1 commit into from
Jul 13, 2021

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Jul 13, 2021 •
edited
Loading

Motivation for this change

Bump buf to 0.44.0

@raboof

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 130091 run on x86_64-linux 1

1 package built:
  • buf

@ofborg ofborg bot requested review from raboof and kalbasit July 13, 2021 11:47
@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 13, 2021 •
edited
Loading

Result of nixpkgs-review pr 130091 at 852af2e run on aarch64-linux 1

1 package built successfully:
  • buf
1 suggestion:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/tools/buf/default.nix:22:5:

       |
22 |     ./skip_test_requiring_network.patch
   |     ^

Result of nixpkgs-review pr 130091 at 852af2e run on x86_64-linux 1

1 package built successfully:
  • buf
1 suggestion:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/tools/buf/default.nix:22:5:

       |
22 |     ./skip_test_requiring_network.patch
   |     ^

raboof
raboof approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on an external project, 👍

@raboof raboof merged commit 8eab9a7 into NixOS:master Jul 13, 2021
@raboof
Copy link
Member

raboof commented Jul 13, 2021

  • warning: missing-patch-comment
    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/tools/buf/default.nix:22:5: 
       |
22 |     ./skip_test_requiring_network.patch
   |     ^

Submitted #130102

@raboof raboof mentioned this pull request Jul 13, 2021
Merged
11 tasks
This was referenced Jul 14, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

@otavio otavio otavio approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@06kellyjac @r-rmcgibbo @raboof @otavio