You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, when the a patch is a local file, because it is not upstreamable, we have plenty of control and the file name or embedded message can cover all there is to know. See NixOS/nixpkgs#130102 (comment)
I would like to avoid a situation where we have nonsense commits and nonsense comments littering Nixpkgs, so I suggest we don't report missing comments when the patch is a path expression.
The text was updated successfully, but these errors were encountered:
I prefer that a summary comments are in the Nix file so that the person updating the package can quickly guess if the file is still needed (after reading the release notes). The patch itself can contain more detailed description.
So I would prefer not to remove the check but rather reformulate the message such that it is clearer it is just a suggestion and viewer discretion is advised. For instance, we could add examples where comment would be pointless to the explanation.
We correctly ask for patches to come with a comment because we prefer to fetch them and we have no other place to provide context for the patch. See also https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
However, when the a patch is a local file, because it is not upstreamable, we have plenty of control and the file name or embedded message can cover all there is to know. See NixOS/nixpkgs#130102 (comment)
I would like to avoid a situation where we have nonsense commits and nonsense comments littering Nixpkgs, so I suggest we don't report missing comments when the patch is a path expression.
The text was updated successfully, but these errors were encountered: