Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate deepspeech in favor of stt #121809

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Mozilla fired the team and they founded a new company to continue their work

@davidak

Did not adhere to #116475 entirely, since the package is not just deprecated, but essentially renamed - made only one commit for clarity.

Closes #119496

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs rvolosatovs requested a review from davidak May 5, 2021 14:53
@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build stt

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 5, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 121809 at 1aa16fdc run on x86_64-linux 1

1 package built successfully:
  • stt
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/audio/stt/default.nix:21:3:

       |
    21 |   installPhase = ''
       |   ^
    
  • warning: no-uri-literals

    URI literals are deprecated.
    Near pkgs/tools/audio/stt/default.nix:28:16:

       |
    28 |     homepage = https://github.com/coqui-ai/STT;
       |                ^
    

@davidak
Copy link
Member

davidak commented May 5, 2021

@rvolosatovs thanks!

Can you use git mv, so blame and history still works?

Also follow the 2. suggestion from @r-rmcgibbo https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md

@davidak
Copy link
Member

davidak commented May 14, 2021

@rvolosatovs can you have a look?

Mozilla fired the team and they founded a new company to continue their work

NixOS#119496
@rvolosatovs
Copy link
Member Author

rvolosatovs commented May 20, 2021

Sorry for taking so long.
Rebased on latest master and commited git mv in 33b0e0d - it doesn't look like this can be squashed in one commit, since then git treats this diff as a deletion and a new file addition due to amount of changes.

@davidak
Copy link
Member

davidak commented May 21, 2021

Result of nixpkgs-review pr 121809 run on x86_64-linux 1

1 package built:
  • stt

@davidak
Copy link
Member

davidak commented May 21, 2021

tts --text "To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do!"

[nix-shell:~]$ stt --model coqui-stt-0.9.3-models.pbmm --scorer coqui-stt-0.9.3-models.scorer --audio '/home/davidak/Downloads/tts-0.0.14.wav' 
TensorFlow: v2.3.0-6-g23ad988fcde
 Coqui STT: v0.10.0-alpha.4-74-g49cdf7a6
2021-05-21 23:11:10.956472: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN)to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
rate: rate clipped 1 samples; decrease volume?
to help with the large amounts of pull requests we would appreciate your reviews of other poll requests especially simple package up dates just leave a comment describing what you have tested in the relevant packages service reviewing helps to reduce the average time to merge for every one thanks a lot if you do

That's quiet good.

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Builds, works

@davidak davidak merged commit 3ff0ef5 into NixOS:master May 21, 2021
@rvolosatovs rvolosatovs deleted the init/stt branch May 25, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update Mozilla TTS/STT
3 participants