doc: add instructions to remove a package #116475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: documentation
|
FYI I can just press that button for a preview.
|
davidak
force-pushed
the
doc-remove-packages
branch
from
acc4de7 to
a6e1655
Compare
|
I finally found the time to update it. Feel free to give feedback! |
|
@FRidh where is the right place to add python aliases? |
|
Package sets typically do not have aliases. |
FRidh
requested changes
Apr 3, 2021
davidak
force-pushed
the
doc-remove-packages
branch
from
a6e1655 to
7ebb9e0
Compare
Not merged yet. |
|
Can we get this merged? |
|
Can you add your review again? |
2 tasks
siraben
requested changes
Apr 19, 2021
siraben
reviewed
Apr 19, 2021
davidak
commented
Apr 20, 2021
Co-authored-by: Sandro <[email protected]> Co-authored-by: Ben Siraphob <[email protected]>
davidak
force-pushed
the
doc-remove-packages
branch
from
b336ef3 to
c0b5d5b
Compare
|
@siraben thanks. i accepted the suggestions except one. take a look if you agree that this makes sense i also squashed, so it could get merged now |
samueldr
approved these changes
Apr 21, 2021
siraben
approved these changes
Apr 22, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It was not documented and i had to reverse engineer it.
It don't really fit in that place and the style is different than the rest. I wish every task would be explained that detailed, so everyone can do it.
Preview
https://github.com/NixOS/nixpkgs/pull/116475/files?short_path=ba88122#diff-ba881223dddc816723e79c2ee074df7b18a08b6520273c22665143b700f3f52d
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)