Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: pip: 20.2.4 -> 20.3 #105540

Closed
wants to merge 2 commits into from
Closed

python: pip: 20.2.4 -> 20.3 #105540

wants to merge 2 commits into from

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Dec 1, 2020

Motivation for this change

Updates to the latest version of pip. I imagine this is a fairly large thing to test. I just thought that I'd throw up a PR in any case to get things started.

The --build argument has been deprecated in pip 20.3. See: pypa/pip#9049

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

};

nativeBuildInputs = [ bootstrapped-pip ];

patches = lib.optionals isPy27 [
(fetchpatch {
url = "https://github.com/pypa/pip/commit/94fbb6cf78c267bf7cdf83eeeb2536ad56cfe639.patch";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch made it with the 20.3 release:
pypa/pip#8666

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already doing a pretty large update here: #105368

I think this should be put off until after we are done stabilizing.

cc @FRidh

@@ -11,7 +11,7 @@ pipInstallPhase() {
export PYTHONPATH="$out/@pythonSitePackages@:$PYTHONPATH"

pushd dist || return 1
@pythonInterpreter@ -m pip install ./*.whl --no-index --no-warn-script-location --prefix="$out" --no-cache $pipInstallFlags --build tmpbuild
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --build argument has been deprecated in pip 20.3. See: pypa/pip#9049

@groodt
Copy link
Contributor Author

groodt commented Dec 1, 2020

We are already doing a pretty large update here: #105368

I think this should be put off until after we are done stabilizing.

cc @FRidh

Awesome! No worries. 👍

@groodt groodt mentioned this pull request Dec 1, 2020
10 tasks
@FRidh FRidh self-assigned this Dec 1, 2020
@FRidh
Copy link
Member

FRidh commented Dec 1, 2020

Part of #105368.

@FRidh FRidh closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants