-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: pip: 20.2.4 -> 20.3 #105540
python: pip: 20.2.4 -> 20.3 #105540
Conversation
}; | ||
|
||
nativeBuildInputs = [ bootstrapped-pip ]; | ||
|
||
patches = lib.optionals isPy27 [ | ||
(fetchpatch { | ||
url = "https://github.com/pypa/pip/commit/94fbb6cf78c267bf7cdf83eeeb2536ad56cfe639.patch"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch made it with the 20.3 release:
pypa/pip#8666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -11,7 +11,7 @@ pipInstallPhase() { | |||
export PYTHONPATH="$out/@pythonSitePackages@:$PYTHONPATH" | |||
|
|||
pushd dist || return 1 | |||
@pythonInterpreter@ -m pip install ./*.whl --no-index --no-warn-script-location --prefix="$out" --no-cache $pipInstallFlags --build tmpbuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --build argument has been deprecated in pip 20.3. See: pypa/pip#9049
Part of #105368. |
Motivation for this change
Updates to the latest version of pip. I imagine this is a fairly large thing to test. I just thought that I'd throw up a PR in any case to get things started.
The
--build
argument has been deprecated in pip 20.3. See: pypa/pip#9049Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)