-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python packages set: major updates #105368
Conversation
numpy needs numpy/numpy#17776 |
the use of flit_core is making gimp fail because python2Packages.flit_core is disabled, which failing the eval as gimp is a darwin constituent https://gist.github.com/GrahamcOfBorg/f0aa782e418d7d426a7bf7a5a7372186 |
maybe we should revert the packaging bump until they figure out their existence. |
the use of flit_core is making gimp fail because python2Packages.flit_core is disabled, which failing the eval as gimp is a darwin constituent https://gist.github.com/GrahamcOfBorg/f0aa782e418d7d426a7bf7a5a7372186 In principle the Python 3 flit can make a wheel for Python 2 (they're universal wheels). I've been avoiding this but can use this fact. Easiest here is to just keep another package for Python 2. |
I had a quick look at this approach. Fun stuff! So, in principle we could run the Really the best approach here, if we were caring sufficiently for Python 2, would be to separate the wheel building part into a separate derivation. The installation function could then simply pick the universal wheel built with Python 3. Now I would still like to do that some day, and not for Python 2, but for other reasons, but not anytime soon. So for now I suggest we keep the older packaging for Python 2 around. |
what do you want to do about:
TMPDIR is already set during build, so we could just remove this option if I'm realing this correctly |
meant to be used with pytest_6
Tests cannot be ran concurrently
Pip had the option --build to build in a custom or temporary directory. Nowadays, pip just listens to TMPDIR, which we already set. This option was deprecated and is removed in pip 20.3.
b31f6e7
to
b0e3728
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/upcoming-python-breakage/7554/19 |
Thank you @jonringer. There are about 900 failures left, which is about the same as it was before. I've updated to the latest pip. |
After this was merged on staging:
|
Seems to be caused by TeX Live depending on Python 2. |
I have TeX Live working; will request pull later. |
Motivation for this change
It's been a long time since we did major updates in the whole set. Applications were not automatically updated, but likely need some fixing as well.
https://hydra.nixos.org/jobset/nixpkgs/python-unstable
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)