Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipmiview: 2.16.0 -> 2.17.0 #100534

Closed
wants to merge 2 commits into from
Closed

ipmiview: 2.16.0 -> 2.17.0 #100534

wants to merge 2 commits into from

Conversation

mweinelt
Copy link
Member

Motivation for this change

Noticed the build was broken due to #100532, decided to fix it because I use the tool sometimes.

It had an invalid desktop item category. Also decided to update it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from vlaci October 15, 2020 00:09
@piegamesde piegamesde mentioned this pull request Oct 15, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 15, 2020
@vlaci
Copy link
Contributor

vlaci commented Oct 15, 2020

I'd rather merge #92053 It contains an additional fix for iKVM_ssl.jar which is needed for 2.17

@mweinelt
Copy link
Member Author

Sure, I missed that. Thanks for pointing that out.

@mweinelt mweinelt closed this Oct 15, 2020
@mweinelt mweinelt deleted the ipmiview branch October 15, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlaci vlaci Awaiting requested review from vlaci

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @vlaci