Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Fix broken desktop files and mark packages as broken #100532

Merged
merged 1 commit into from
Nov 27, 2020
Merged

treewide: Fix broken desktop files and mark packages as broken #100532

merged 1 commit into from
Nov 27, 2020

Conversation

piegamesde
Copy link
Member

@piegamesde piegamesde commented Oct 14, 2020 •
edited
Loading

This fixes all packages that are failed nixpkgs-review in #91790.
Packages that were broken prior to that PR were marked as broken.
Packages that failed because of #75729 were fixed.

Affected packages:

Package Broken reason Fix Maintainer ping
frogatto Build failure Mark as broken @astro
ipmiview Desktop file broken Disable validation Fixed in #100534 #92053 @vlaci
ostinato Desktop file broken Disable validation @rick68
python37Packages.spyder Build failure Mark as broken Fixed on master @gebner
react-native-debugger Desktop file broken Disable validation Fixed on master No maintainers!
sage Python tests fail Mark as broken @timokau
sageWithDoc Python tests fail Mark as broken @timokau
softmaker-office Hash mismatch in fixed output derivation Mark as broken Fixed on master @danieldk
tdm Desktop file broken Disable validation @cizra
termius Download URL 403 Mark as broken @Br1ght0ne
toggldesktop libtoggl build failure Mark as broken @yegortimoshenko
tome2 Desktop file broken Disable validation @cizra
ut2004demo Download URL 404 Mark as broken Fixed in #100424 @abbradar
Motivation for this change

Less build failures!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review 100532"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 14, 2020
@mweinelt mweinelt mentioned this pull request Oct 15, 2020
Closed
10 tasks
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 15, 2020
@ofborg ofborg bot requested review from rick68 and cizra October 15, 2020 00:18
@piegamesde piegamesde changed the title various packages: Fix broken desktop files and mark packages as broken treewide: Fix broken desktop files and mark packages as broken Oct 15, 2020
@ajs124
Copy link
Member

ajs124 commented Oct 15, 2020 •
edited
Loading

ut2004demo should be fixed after #100424

danieldk
danieldk suggested changes Oct 15, 2020
View reviewed changes
pkgs/applications/science/math/sage/sage.nix
@@ -61,6 +61,7 @@ stdenv.mkDerivation rec {
};

meta = with stdenv.lib; {
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mark Softmaker Office or FreeOffice broken. Hash mismatches occur every time upstream updates SoftMaker/FreeOffice (because they replace old versions), but this is usually fixed in a few days at most.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, SoftMaker/FreeOffice currently seem to build fine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@timokau
Copy link
Member

timokau commented Oct 15, 2020

👍 on sage, it has unfortunately been broken for a while and its better to be honest.

@gebner
Copy link
Member

gebner commented Oct 15, 2020

Please don't mark spyder as broken, this used to work just a few days ago.

@piegamesde
Copy link
Member Author

It seems that using an older branch is biting me. I'll have a look on how things look on master.

@gebner
Copy link
Member

gebner commented Oct 15, 2020 •
edited
Loading

Update: cq-editor (which uses spyder) still builds and works fine on master.

@vlaci
Copy link
Contributor

vlaci commented Oct 15, 2020

#92053 is a better fix for ipmiview.

@piegamesde
treewide: Fix broken desktop files and mark packages as broken
e14a359 
This fixes all packages that are failed `nixpkgs-review` in NixOS#91790.
Packages that were broken prior to that PR were marked as broken.
Packages that failed because of NixOS#75729 were fixed.
@piegamesde
Copy link
Member Author

I've now rebased onto master and re-checked all applications. I am sorry for the false positives and I hope that they are all removed by now.

@ofborg ofborg bot removed the 6.topic: python label Oct 15, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 100532 run on x86_64-linux 1

3 packages built:
  • ostinato
  • tdm
  • tome2

@SuperSandro2000 SuperSandro2000 merged commit ec421ca into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@rick68 rick68 Awaiting requested review from rick68

@cizra cizra Awaiting requested review from cizra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@piegamesde @ajs124 @timokau @gebner @vlaci @SuperSandro2000 @danieldk