-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twemoji-color-font: Use release tarball font instead of building from source to reduce build times? #97871
Comments
I'm conflicted: on one hand NixOS is a source based distribution and building from source makes it possible to apply patches and whatnot, but on the other it's just a font without any executable stuff and 1.5 hours is a lot. I guess it depends on how valuable build time is? |
It seems quite common for fonts in nixpkgs to use the upstream-release-provided font files; examples I picked randomly by clicking around in Some fonts are generated by a call to So I propose to make |
|
Ow. Well, that's a good enough reason to switch I guess :) I'll open a pr. |
cc @jtojnar |
I have a sentiment for source builds but no rational arguments. The above arguments for building We also have |
Yeah, I'm similar (at least for fonts, outside fonts there's many rational arguments 🤣 ). And I think considering how it times out... It's the best choice for now as there's not a ton of benefit to argue. Though 13rac1/twemoji-color-font#83 doesn't seem to be incredibly difficult to do :frowning_face. |
I think in practice this is still not going to address the root issue that the calling of inkscape is highly inefficient. |
I'm sorry, I confused the two packages. It's apparently the other one that's timing out on Hydra: https://hydra.nixos.org/job/nixos/release-20.03/nixpkgs.twitter-color-emoji.x86_64-linux |
Even with the 5x speedup I found in 13rac1/twemoji-color-font#83 it'd still take 20 minutes to build it though. If somebody goes through the effort of fixing it upstream, we may want to consider switching back to fully-from-source. But there are 1000s of open-source tasks higher than this on my list :) |
Can relate. (says ever opensource contributor ever while submitting 10x README PRs in a day 😁 ) |
Building from sources takes 1.5 hours on hydra for minimal advantages. Relevant discussion: NixOS#97871
Building from sources takes 1.5 hours on hydra for minimal advantages. Relevant discussion: #97871
The package
twemoji-color-font
takes a long time to build the individual glyphs using e.g. 1.5 hours on Hydra.See also 13rac1/twemoji-color-font#83.
Other distros simply use the release tarball (e.g. AUR here) which already has the resulting 13 MB
.ttf
file prebuilt.Should we do this as well, given that it's a font?
CC maintainer: @fgaz
The text was updated successfully, but these errors were encountered: