Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: emojione #326959

Closed
l0b0 opened this issue Jul 14, 2024 · 3 comments · Fixed by #327420
Closed

Build failure: emojione #326959

l0b0 opened this issue Jul 14, 2024 · 3 comments · Fixed by #327420
Labels
0.kind: build failure A package fails to build

Comments

@l0b0
Copy link
Contributor

l0b0 commented Jul 14, 2024

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix-build -A emojione on current master, 9665639

Build log

https://gist.github.com/l0b0/bf338fbde6ed5cb53ebed4dd9f1260d1

Additional context

Notify maintainers

@abbradar

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.9.9, NixOS, 24.11 (Vicuna), 24.11pre652179.7e7c39ea35c5
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.18.5
  • channels(root): "nixos, nixos-hardware"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Add a 👍 reaction to issues you find important.

@l0b0 l0b0 added the 0.kind: build failure A package fails to build label Jul 14, 2024
@ghpzin
Copy link
Contributor

ghpzin commented Jul 14, 2024

Error in logs from scfbuild:

scfbuild -c scfbuild.yml -o build/EmojiOneColor-SVGinOT.ttf --font-version="1.4"
scfbuild -c scfbuild-osx.yml -o build/EmojiOneColor-SVGinOT-OSX.ttf --font-version="1.4"
Traceback (most recent call last):
  File "/nix/store/ypqis4mag1g2015j9zm4rfq0xa12q48m-scfbuild-2.0.0/bin/.scfbuild-wrapped", line 15, in <module>
    from scfbuild.main import main
  File "/nix/store/ypqis4mag1g2015j9zm4rfq0xa12q48m-scfbuild-2.0.0/lib/python3.12/site-packages/scfbuild/main.py", line 18, in <module>
    from .builder import Builder
  File "/nix/store/ypqis4mag1g2015j9zm4rfq0xa12q48m-scfbuild-2.0.0/lib/python3.12/site-packages/scfbuild/builder.py", line 14, in <module>
    from distutils.version import LooseVersion
ModuleNotFoundError: No module named 'distutils'
Traceback (most recent call last):
  File "/nix/store/ypqis4mag1g2015j9zm4rfq0xa12q48m-scfbuild-2.0.0/bin/.scfbuild-wrapped", line 15, in <module>
    from scfbuild.main import main
  File "/nix/store/ypqis4mag1g2015j9zm4rfq0xa12q48m-scfbuild-2.0.0/lib/python3.12/site-packages/scfbuild/main.py", line 18, in <module>
    from .builder import Builder
  File "/nix/store/ypqis4mag1g2015j9zm4rfq0xa12q48m-scfbuild-2.0.0/lib/python3.12/site-packages/scfbuild/builder.py", line 14, in <module>
    from distutils.version import LooseVersion
ModuleNotFoundError: No module named 'distutils'
make: *** [Makefile:102: build/EmojiOneColor-SVGinOT.ttf] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:105: build/EmojiOneColor-SVGinOT-OSX.ttf] Error 1

Upstream maintenance status for this is quite questionable, current repo for emojione is archived since 2018:
https://github.com/13rac1/emojione-color-font

This repository has been archived by the owner on Nov 10, 2018. It is now read-only.
End of Life. Switch to https://github.com/eosrei/twemoji-color-font

It is a 20 min build on hydra for resulting fonts that are unlikely to ever change.

Fix for scfbuild is pretty easy - just patching distutils part and add looseversion to dependencies (or even remove that check altogether because fonttools version in nixpkgs has been over 2.5 for years):

diff --git a/scfbuild/builder.py b/scfbuild/builder.py
index 6f023b8..7ba811e 100644
--- a/scfbuild/builder.py
+++ b/scfbuild/builder.py
@@ -11,7 +11,7 @@ import os
 import sys
 import tempfile
 import time
-from distutils.version import LooseVersion
+from looseversion import LooseVersion
 import xml.etree.ElementTree as ET

 import fontTools

But considering it is archived it may be better to either drop both (as nothing else seem to depend on scfbuild) or switch to release tarball similar to twemoji-color-font:
#97871

@l0b0
Copy link
Contributor Author

l0b0 commented Jul 15, 2024

I wouldn't remind emojione being removed if there's a useful alternative. I don't know of a good way to get complete coverage over emojis, and so far I've installed emojione, nerdfonts, noto-fonts, stix-two, and twemoji-color-font, none of which seem to cover any of the other emoji code points completely.

@LuNeder
Copy link
Contributor

LuNeder commented Jul 15, 2024

Potentially related: #325909 and #253751

Potential fix: https://github.com/NixOS/nixpkgs/pull/325909/files or #325773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants