Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocmPackages.llvm: add setuptools #325909

Merged
merged 2 commits into from
Jul 10, 2024
Merged

rocmPackages.llvm: add setuptools #325909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af59eb8
rocmPackages.llvm: add setuptools
khaneliman Jul 9, 2024
09bcfca
rocmPackages.llvm.libcxx: exclude a few failing tests
khaneliman Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/development/rocm-modules/6/llvm/base.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ in stdenv.mkDerivation (finalAttrs: {
cmake
ninja
git
python3Packages.python
(python3Packages.python.withPackages (p: [ p.setuptools ]))
khaneliman marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What bothers me a bit is that recommonmark used a bit down below is not included in this environment. But if it works, I guess it is OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the first iteration of the PR was including it similar to that package, I dont understand why this works and that didn't...

] ++ lib.optionals (buildDocs || buildMan) [
doxygen
sphinx
Expand Down
4 changes: 4 additions & 0 deletions pkgs/development/rocm-modules/6/llvm/stage-2/1000-libcxx-failing-tests.list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,3 +169,7 @@
../libcxx/test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_allocate_overaligned_request.pass.cpp
../libcxx/test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_allocate_reuse_blocks.pass.cpp
../libcxx/test/std/utilities/utility/mem.res/mem.res.pool/mem.res.pool.mem/unsync_allocate.pass.cpp
../libcxx/test/std/language.support/support.dynamic/hardware_inference_size.compile.pass.cpp
../libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp
../libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp
../libcxx/test/libcxx/selftest/sh.cpp/empty.sh.cpp