Deprecate use of stdenv.lib across Nixpkgs #108938

siraben · 2021-01-10T11:47:32Z

Carry over discussion from IRC #nixos-dev and #108934. Inspired by the doc change in c06b2b3 recommending top-level usage of lib over stdenv.lib, we want to reduce confusion for newcomers and unnecessary complexity by making lib the canonical way to access the Nix library. We may still want to keep stdenv.lib to not break external code, and place a trace or similar at its definition site.

$ nix-shell -p ag --run 'ag "stdenv\.lib" -l | wc -l'
11783

There are over 11000 files where stdenv.lib occurs at least once. Beyond splitting this change across multiple PRs, in what ways can the change be automated?

Pinging @alyssais @Profpatsch @FRidh @Atemu @ehmry

The text was updated successfully, but these errors were encountered:

siraben · 2021-01-10T11:50:56Z

In the short term, we could add this check in ofbrorg and nix-hammering, and update any examples in the documentation to reduce new usage of stdenv.lib.

TredwellGit · 2021-01-10T13:13:40Z

$ rg '[sS]tdenv.*\.lib' | wc -l
45311

Don't forget things like stdenvNoCC.lib and clangStdenv.lib.

siraben · 2021-01-10T13:16:42Z

Ah. So 45K occurrences across 11.8K files.

$ ag '[sS]tdenv.*\.lib' -l | wc -l
11853

Profpatsch · 2021-01-10T16:45:29Z

toplevel is done #108934

Profpatsch · 2021-01-10T16:46:06Z

the xorg dep generator also doesn’t put it in its output anymore #108935

Profpatsch · 2021-01-10T21:23:28Z

meta = with stdenv.lib; trewide rewrite in #108978

Profpatsch · 2021-01-10T21:33:56Z

doc changes in #108979

Part of: NixOS#108938 Changing the documentation to not refer to stdenv.lib is the first step to make people use it directly.

Part of: #108938 Changing the documentation to not refer to stdenv.lib is the first step to make people use it directly.

Part of: NixOS#108938 meta = with stdenv.lib; is a widely used pattern. We want to slowly remove the `stdenv.lib` indirection and encourage people to use `lib` directly. Thus let’s start with the meta field. This used a rewriting script to mostly automatically replace all occurances of this pattern, and add the `lib` argument to the package header if it doesn’t exist yet. The script in its current form is available at https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix

Part of: #108938 meta = with stdenv.lib; is a widely used pattern. We want to slowly remove the `stdenv.lib` indirection and encourage people to use `lib` directly. Thus let’s start with the meta field. This used a rewriting script to mostly automatically replace all occurances of this pattern, and add the `lib` argument to the package header if it doesn’t exist yet. The script in its current form is available at https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix

alyssais · 2021-01-11T09:47:37Z

Graph of stdenv.lib occurrences over time: https://edef.eu/~qyliss/nix/lib/

siraben · 2021-01-11T09:50:04Z

Nice! What scripts did you use to generate it?

alyssais · 2021-01-11T10:04:04Z

Nice! What scripts did you use to generate it?

There's a source code link now :)

undortunatrely I still see ``` trace: Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `lib` instead. For more information see NixOS/nixpkgs#108938 ```

Fixes this message on nixpkgs-unstable: trace: Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `pkgs.lib` instead. For more information see NixOS/nixpkgs#108938 Signed-off-by: Anders Kaseorg <[email protected]>

This is in preparation for the `stdenv.lib` removal. Strangely, the warning persists. I assume it comes from some expressions that are outside of this repo and we only transitively pull in. This is the warning we eventually want to fix: ``` trace: Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `lib` instead. For more information see NixOS/nixpkgs#108938 ```

See NixOS/nixpkgs#108938

samuela · 2021-10-05T02:04:07Z

I just got this warning while doing a home-manager switch, but it doesn't give me any info as to which derivations are at fault. Is there any way we could improve the message to identify culprits?

jtojnar · 2021-10-05T02:52:44Z

@samuela With config.nixpkgs.allowAliases = false;, you should get a hard error which will allow you to use --show-trace. Or you can update Nixpkgs, since it has been removed in d2c9f81.

see issue NixOS/nixpkgs#108938

stdenv.lib is deprecated in nixpkgs see NixOS/nixpkgs#108938

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

Fixes: Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `pkgs.lib` instead. For more information see NixOS/nixpkgs#108938

On Nixpkgs, the work[1] for deprecating stdenv.lib has started. This patch updates the generator, existing documentation and tests to use the top-level lib attribute to access the standard library, instead of stdenv.lib. [1]: NixOS/nixpkgs#108938

In Nixpkgs stdenv.lib is deprecated[1] and may be removed in the future. [1]: NixOS/nixpkgs#108938

* Nix maintenance - stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources * Add Nix workflow * Adjust Nix build to use oxide target * Use auth token for cachix Co-authored-by: Nathaniel van Diepen <[email protected]>

Running `nix develop` prints a warning message about using this deprecated attribute. See NixOS/nixpkgs#108938

Running `nix develop` prints a warning message about using this deprecated attribute. See NixOS/nixpkgs#108938 Update oldNixpkgs to the latest working version

siraben added the 3.skill: sprintable A larger issue which is split into distinct actionable tasks label Jan 10, 2021

alyssais added the 6.topic: best practices label Jan 10, 2021

alyssais added this to the 21.03 milestone Jan 10, 2021

TredwellGit mentioned this issue Jan 10, 2021

x11/xorg: stdenv.lib -> lib in meta generator #108935

Merged

10 tasks

kira-bruneau mentioned this issue Jan 10, 2021

yabridge,yabridgectl: init at 3.0.0 #108835

Merged

10 tasks

Profpatsch mentioned this issue Jan 10, 2021

treewide: with stdenv.lib; in meta -> with lib; #108978

Merged

10 tasks

Profpatsch mentioned this issue Jan 10, 2021

doc: stdenv.lib -> lib #108979

Merged

10 tasks

Profpatsch mentioned this issue Jan 10, 2021

treewide: simplify pkgs.stdenv.lib -> pkgs.lib #108970

Merged

cole-h mentioned this issue Jan 11, 2021

psw: init at 0.1.2 #108986

Merged

10 tasks

siraben mentioned this issue Jan 11, 2021

chisel: init at 1.7.3 #108931

Merged

10 tasks

Profpatsch added a commit to Profpatsch/nixpkgs that referenced this issue Jan 11, 2021

doc: stdenv.lib -> lib

82cfb22

Part of: NixOS#108938 Changing the documentation to not refer to stdenv.lib is the first step to make people use it directly.

Profpatsch added a commit that referenced this issue Jan 11, 2021

doc: stdenv.lib -> lib

b0c1583

Part of: #108938 Changing the documentation to not refer to stdenv.lib is the first step to make people use it directly.

Riscky mentioned this issue Sep 10, 2021

Nix warns that stdenv.lib is deprecated svsticky/constipated-koala#877

Closed

bobby285271 mentioned this issue Sep 19, 2021

Add systemd support elementary/session-settings#55

Merged

tazjin added a commit to tazjin/nix-diff that referenced this issue Sep 24, 2021

nix: 'lib' is no longer accessible via stdenv

597c5b3

See NixOS/nixpkgs#108938

tazjin mentioned this issue Sep 24, 2021

nix: 'lib' is no longer accessible via stdenv Gabriella439/nix-diff#43

Merged

Gabriella439 pushed a commit to Gabriella439/nix-diff that referenced this issue Sep 24, 2021

nix: 'lib' is no longer accessible via stdenv (#43)

bc1adbc

See NixOS/nixpkgs#108938

prehonor mentioned this issue Oct 10, 2021

error with installing ventoy-bin ！ #141158

Closed

pSub added a commit to pSub/pascal-wittmann.de that referenced this issue Oct 26, 2021

stdenv.lib → lib

614da77

see issue NixOS/nixpkgs#108938

DeeUnderscore added a commit to DeeUnderscore/dub2nix that referenced this issue Nov 14, 2021

use pkgs.lib instead of stdenv.lib

efa5e6f

stdenv.lib is deprecated in nixpkgs see NixOS/nixpkgs#108938

DeeUnderscore mentioned this issue Nov 14, 2021

use pkgs.lib instead of stdenv.lib lionello/dub2nix#10

Merged

rissson mentioned this issue Dec 4, 2021

pkgs: stdenv.lib -> lib kalbasit/nur-packages#9

Closed

siraben added a commit to siraben/oxide that referenced this issue Jan 7, 2022

Nix maintanence

04aac6b

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

siraben added a commit to siraben/oxide that referenced this issue Jan 7, 2022

Nix maintanence

843fb6e

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

siraben added a commit to siraben/oxide that referenced this issue Jan 7, 2022

Nix maintanence

8787385

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

siraben added a commit to siraben/oxide that referenced this issue Jan 7, 2022

Nix maintenance

040dcf0

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

siraben added a commit to siraben/oxide that referenced this issue Jan 10, 2022

Nix maintenance

037f657

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

siraben added a commit to siraben/oxide that referenced this issue Feb 1, 2022

Nix maintenance

dc66dad

- stdenv.lib has been deprecated (NixOS/nixpkgs#108938) - replace linuxkit-nix (unmaintained) with nix-docker - updated niv sources

sternenseemann pushed a commit to NixOS/cabal2nix that referenced this issue Jul 21, 2022

Use lib instead of stdenv.lib

5d881fb

In Nixpkgs stdenv.lib is deprecated[1] and may be removed in the future. [1]: NixOS/nixpkgs#108938

scarf005 mentioned this issue Jun 2, 2023

stdenv.lib deprecation warning on installation obsidiansystems/obelisk#1034

Open

resonant-riches added a commit to ChorusOne/azimuth-cli that referenced this issue Feb 20, 2024

Stop using deprecated stdenv.lib

879fe7d

Running `nix develop` prints a warning message about using this deprecated attribute. See NixOS/nixpkgs#108938

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate use of stdenv.lib across Nixpkgs #108938

Deprecate use of stdenv.lib across Nixpkgs #108938

siraben commented Jan 10, 2021

siraben commented Jan 10, 2021

TredwellGit commented Jan 10, 2021

siraben commented Jan 10, 2021

Profpatsch commented Jan 10, 2021

Profpatsch commented Jan 10, 2021

Profpatsch commented Jan 10, 2021 •

edited

Loading

Profpatsch commented Jan 10, 2021

alyssais commented Jan 11, 2021 via email

siraben commented Jan 11, 2021

alyssais commented Jan 11, 2021 via email

samuela commented Oct 5, 2021

jtojnar commented Oct 5, 2021

Deprecate use of stdenv.lib across Nixpkgs #108938

Deprecate use of stdenv.lib across Nixpkgs #108938

Comments

siraben commented Jan 10, 2021

siraben commented Jan 10, 2021

TredwellGit commented Jan 10, 2021

siraben commented Jan 10, 2021

Profpatsch commented Jan 10, 2021

Profpatsch commented Jan 10, 2021

Profpatsch commented Jan 10, 2021 • edited Loading

Profpatsch commented Jan 10, 2021

alyssais commented Jan 11, 2021 via email

siraben commented Jan 11, 2021

alyssais commented Jan 11, 2021 via email

samuela commented Oct 5, 2021

jtojnar commented Oct 5, 2021

Profpatsch commented Jan 10, 2021 •

edited

Loading