Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psw: init at 0.1.2 #108986

Merged
merged 1 commit into from
Jan 11, 2021
Merged

psw: init at 0.1.2 #108986

merged 1 commit into from
Jan 11, 2021

Conversation

Wulfsta
Copy link
Member

@Wulfsta Wulfsta commented Jan 10, 2021

Motivation for this change

Add psw. Full disclosure, I wrote this tool. I needed a source of randomness quicker than /dev/urandom that was not suited for cryptographic purposes, and since I packaged it for NixOS I figured I'd submit a PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech
Copy link
Contributor

iblech commented Jan 10, 2021

I just tested this; works fine! I can see how this can be useful. Thanks!

@Wulfsta
Copy link
Member Author

Wulfsta commented Jan 11, 2021

@GrahamcOfBorg eval

@Wulfsta
Copy link
Member Author

Wulfsta commented Jan 11, 2021

@iblech Thanks for testing!

cole-h
cole-h requested changes Jan 11, 2021
View reviewed changes
pkgs/tools/misc/psw/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/psw/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/psw/default.nix Show resolved Hide resolved
cole-h
cole-h approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Result of nixpkgs-review pr 108986 run on x86_64-linux 1

1 package built:
  • psw

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jan 11, 2021
@cole-h cole-h merged commit 5ca3562 into NixOS:master Jan 11, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108986 run on x86_64-linux 1

1 package built:
  • psw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wulfsta @iblech @SuperSandro2000 @cole-h