-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto cargo updates #67
Conversation
example outputcargo changescargo upgrade
cargo update
cargo outdated
cargo audit
npins changes
|
I was messing around with `cargo audit` and `cargo outdated` and realized I broke the auto-update of cargo. When I switched from using `cargo update` to `cargo upgrade`, I didn't realize that `cargo upgrade` doesn't update the `Cargo.lock` file. I only noticed because `cargo audit` was reporting a yanked version of libc and running `cargo update` fixed it. I added running `cargo outdated` as a sanity check that things are updating correcty.
@infinisil think we should change this to be an array? I think the order the steps are written to the script are indeterminate (npins update may run last for example). |
Recently found on some private Rust repos I maintain that dependabot doesn't "just update everything" like I thought. This bespoke script to run cargo commands is starting to look more appealing to me. |
Since it's sorted, the order is assured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was messing around with
cargo audit
andcargo outdated
and realized I broke the auto-update of cargo.When I switched from using
cargo update
tocargo upgrade
#61, I didn't realize thatcargo upgrade
doesn't update theCargo.lock
file.I only noticed because
cargo audit
was reporting a yanked version of libc and runningcargo update
fixed it.I added running
cargo outdated
as a sanity check that things are updating correctly.