Switch to using cargo-edit for cargo upgrade command

[willbush]

The current cargo update command updates the version of dependencies in the Cargo.lock file based on the semver compatibility. It will not change the version range specified in the Cargo.toml file.

[willbush]

Ran this locally to test (had to comment out githubActions in default.nix:

cargo changes

    Updating 'https://github.com/rust-lang/crates.io-index' index
    Checking nixpkgs-check-by-name's dependencies
name          old req compatible latest  new req
====          ======= ========== ======  =======
regex         1.9.3   1.10.4     1.10.4  1.10.4
clap          4.3.23  4.5.4      4.5.4   4.5.4
serde_json    1.0.105 1.0.116    1.0.116 1.0.116
tempfile      3.8.0   3.10.1     3.10.1  3.10.1
serde         1.0.185 1.0.200    1.0.200 1.0.200
colored       2.0.4   2.1.0      2.1.0   2.1.0
rowan         0.15.11 0.15.15    0.15.15 0.15.15
indoc         2.0.4   2.0.5      2.0.5   2.0.5
relative-path 1.9.2   1.9.3      1.9.3   1.9.3
temp-env      0.3.5   0.3.6      0.3.6   0.3.6
   Upgrading recursive dependencies
    Updating libc v0.2.153 -> v0.2.154
    Updating rustix v0.38.33 -> v0.38.34
note: Re-run with `--incompatible` to upgrade incompatible version requirements
note: Re-run with `--verbose` to show more dependencies
  incompatible: itertools
  latest: 4 packages

Running /nix/store/37c31fdckdpmyk3024xh2fwrbm48y2lm-update-npins

npins changes

[INFO ] Updating 'nixpkgs' …
Changes:
-    url: https://releases.nixos.org/nixpkgs/nixpkgs-24.05pre615035.f2d7a289c5a5/nixexprs.tar.xz
+    url: https://releases.nixos.org/nixpkgs/nixpkgs-24.05pre622008.ee4a6e0f566f/nixexprs.tar.xz
-    hash: 1dz3qjnvrqk8j0i90dn2lz64p51mva1cizznhshas1pbr4v2p2za
+    hash: 0pa8g6a8xg03pbqc98vm36cffjpk5ihmfa43vms86zb4xc1hq1n4
[INFO ] Updating 'treefmt-nix' …
Changes:
-    revision: 49dc4a92b02b8e68798abd99184f228243b6e3ac
+    revision: c6aaf729f34a36c445618580a9f95a48f5e4e03f
-    url: https://github.com/numtide/treefmt-nix/archive/49dc4a92b02b8e68798abd99184f228243b6e3ac.tar.gz
+    url: https://github.com/numtide/treefmt-nix/archive/c6aaf729f34a36c445618580a9f95a48f5e4e03f.tar.gz
-    hash: 0qlhb0xvcc3al19irclxk7vnppd9m6b5vi3nbjb9dylphs306x1p
+    hash: 18491j2law88zdkfxrpg2snbcig34pfcg7ykgjwf6ahbdq313zj2
[INFO ] Update successful.

[philiptaron]

Man, I don't know. semver is just someone's opinion in practice. I kind of prefer the "update and see if it builds and tests" approach we have today.

[willbush]

Man, I don't know. semver is just someone's opinion in practice. I kind of prefer the "update and see if it builds and tests" approach we have today.

I didn't notice that I had to add --incompatible to allow it to jump major versions. I just force pushed a change to add that.

I can't tell if that's what you meant or if you thought I was changing it to respect semver. Currently cargo update won't ever let us know that a new major version exists. cargo upgrade --incompatible will basically upgrade everything to latest and we'll see if it builds and tests.

[philiptaron]

I did some research. I think this works.

[infinisil]

Note that CI also runs the update command for you: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8976276467#summary-24652778846 😉

Looking good to me btw, thanks for taking care of this!