Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement delete endpoint for
Files
,Nodes
,Notes
,Reminders
andTimelines
module #41base: main
Are you sure you want to change the base?
Implement delete endpoint for
Files
,Nodes
,Notes
,Reminders
andTimelines
module #41Changes from 14 commits
64c274b
a75924f
ad0c261
38d41e9
ec8ca94
05ccb51
9229e77
e4ca881
4b75aa6
679a0c4
7a6dd85
708dd41
c8e37a4
f08f8e6
14263e4
dbb5f48
208c22f
b78fc26
3dc8612
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said above, I suggest strongly typed properties in commands and queries. This goes for all modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, they don't seem to be - the
Id
is still ofstring
type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That quoted code is outdated, locally and on GitHub I can see the correct version which is the
Id
type.