Implement delete endpoint for Files, Nodes, Notes, Reminders and Timelines module
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaVetnic
requested changes
Jan 13, 2025
...es/Files/Files.Application/Entities/Files/Commands/DeleteFileAsset/DeleteFileAssetCommand.cs
Outdated
Show resolved
Hide resolved
...es/Files/Files.Application/Entities/Files/Commands/DeleteFileAsset/DeleteFileAssetHandler.cs
Show resolved
Hide resolved
...es/Files/Files.Application/Entities/Files/Commands/DeleteFileAsset/DeleteFileAssetHandler.cs
Outdated
Show resolved
Hide resolved
...es/Timelines.Application/Entities/Timelines/Commands/DeleteTimeline/DeleteTimelineHandler.cs
Outdated
Show resolved
Hide resolved
...es/Timelines.Application/Entities/Timelines/Commands/DeleteTimeline/DeleteTimelineHandler.cs
Outdated
Show resolved
Hide resolved
...rs/Reminders.Application/Entities/Reminders/Commands/DeleteReminder/DeleteReminderHandler.cs
Outdated
Show resolved
Hide resolved
.../src/Modules/Notes/Notes.Application/Entities/Notes/Commands/DeleteNote/DeleteNoteHandler.cs
Outdated
Show resolved
Hide resolved
.../src/Modules/Nodes/Nodes.Application/Entities/Nodes/Commands/DeleteNode/DeleteNodeHandler.cs
Outdated
Show resolved
Hide resolved
…ete command & handler
NikolaVetnic
requested changes
Jan 15, 2025
...s/Files/Files.Application/Entities/Files/Queries/GetFileAssetById/GetFileAssetByIdHandler.cs
Outdated
Show resolved
Hide resolved
...s/Files/Files.Application/Entities/Files/Queries/GetFileAssetById/GetFileAssetByIdHandler.cs
Outdated
Show resolved
Hide resolved
...les/Files/Files.Application/Entities/Files/Queries/GetFileAssetById/GetFileAssetByIdQuery.cs
Show resolved
Hide resolved
| @@ -0,0 +1,15 @@ | |||
| namespace Nodes.Application.Entities.Nodes.Commands.DeleteNode; | |||
|
|
|||
| public record DeleteNodeCommand(string Id) : ICommand<DeleteNodeResult>; | |||
There was a problem hiding this comment.
Like I said above, I suggest strongly typed properties in commands and queries. This goes for all modules.
There was a problem hiding this comment.
Changes made ✅
There was a problem hiding this comment.
Hmm, they don't seem to be - the Id is still of string type.
...src/Modules/Notes/Notes.Application/Entities/Notes/Queries/GetNoteById/GetNoteByIdHandler.cs
Outdated
Show resolved
Hide resolved
...d/src/Modules/Notes/Notes.Application/Entities/Notes/Queries/GetNoteById/GetNoteByIdQuery.cs
Show resolved
Hide resolved
...rs/Reminders.Application/Entities/Reminders/Commands/DeleteReminder/DeleteReminderCommand.cs
Outdated
Show resolved
Hide resolved
...s/Reminders.Application/Entities/Reminders/Queries/GetReminderById/GetReminderByIdHandler.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,15 @@ | |||
| namespace Timelines.Application.Entities.Timelines.Commands.DeleteTimeline; | |||
|
|
|||
| public record DeleteTimelineCommand(string Id) : ICommand<DeleteTimelineResult>; | |||
There was a problem hiding this comment.
Changes made ✅
...s/Timelines.Application/Entities/Timelines/Queries/GetTimelineById/GetTimelineByIdHandler.cs
Outdated
Show resolved
Hide resolved
NikolaVetnic
requested changes
Jan 15, 2025
|
|
||
| namespace Timelines.Application.Entities.Timelines.Commands.DeleteTimeline; | ||
|
|
||
| public class DeleteNodeHandler(ITimelinesDbContext dbContext) : ICommandHandler<DeleteTimelineCommand, DeleteTimelineResult> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I did the following things:
Files,Nodes,Notes,RemindersandTimelinesmoduleDELETEendpoint for:FilesmoduleNodesmoduleNotesmoduleRemindersmoduleTimelinesmodule