Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestSyncrhoneExtensionEscrow implementation #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

requestSyncrhoneExtensionEscrow implementation #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07a51b0
requestSynchrone initial implementation
Gujjar95 Jan 20, 2018
cfd944c
typo
Gujjar95 Jan 20, 2018
e64ca92
Address correction
Gujjar95 Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions servicesExtensions/requestSyncrhoneExtensionEscrow_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,33 @@
from servicesCore.requestCore_service import RequestCoreService
from servicesExternal.web3_single import Web3Single


requestCoreArtifact = Artifacts.requestCoreArtifact
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to do this, they're already imported on line 4 from artifacts import *

requestSynchroneExtensionEscrowArtifact = Artifacts.requestSynchroneExtensionEscrowArtifact
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this line as well.

class RequestSynchroneExtensionEscrowService:
def __init__(self):
pass
global requestCoreArtifact, requestSynchroneExtensionEscrowArtifact
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely not needed either.

self._web3Single = Web3Single.getInstance()
self._abiRequestCore = requestCoreArtifact.abi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifacts need to be interacted with like dicts, so you'll need to do requestCoreArtifact['abi']

self._requestCoreServices = RequestCoreService()
networkName = self._web3Single.networkName
self._abiSynchroneExtensionEscrow = requestSynchroneExtensionEscrowArtifact.abi
if not requestSynchroneExtensionEscrowArtifact[networkName] :
raise ValueError('Escrow Artifact no configuration for network: ' + networkName)
self._addressSynchroneExtensionEscrow = requestSynchroneExtensionEscrowArtifact.networks[networkName].address
self._instanceSynchroneExtensionEscrow = self._web3Single.web3.eth.Contract(
self._abiSynchroneExtensionEscrow,
self._addressSynchroneExtensionEscrow)

def parseParameters(self, extensionParams: List[Any]) -> Any:
pass
if not extensionParams or not self._web3Single.isAddressNoChecksum(extensionParams[0]):
return {'error' : ValueError('first parameter must be a valid eth address')}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange to return a dictionary like this. Is this what the calling functions are expecting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick, so should we raise an error here or any other?

ret : List[Any] = []
#no idea about address parameter
ret.append(self._web3Single.toSolidityBytes32("address", extensionParams[0]))
for i in range(1,9):
ret.append(self._web3Single.toSolidityBytes32('bytes32',0))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appends the same thing 8 times, is there a reason that it's the same thing every time and is there a reason you're doing range(1,9) instead of range(8)

return {'result' : ret}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again with the strange return style, is that what's expected?



def releaseToPayeeAction(self, requestId: str, options: Any = None):
pass
Expand Down