Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evm): commit temporary state on precompile start, avoiding bug stemming from uncommitted, dirty journal entries in the EVM StateDB #2086

Merged
merged 17 commits into from
Oct 24, 2024
+1,298 −686

Merge branch 'ud/evm-fix-state-not-committed-before-precompile' of ht…

62a1b5f
Select commit
Loading
Failed to load commit list.
Merged

fix(evm): commit temporary state on precompile start, avoiding bug stemming from uncommitted, dirty journal entries in the EVM StateDB #2086

Merge branch 'ud/evm-fix-state-not-committed-before-precompile' of ht…
62a1b5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 22, 2024 in 1s

59.21% of diff hit (target 0.00%)

View this Pull Request on Codecov

59.21% of diff hit (target 0.00%)

Annotations

Check warning on line 79 in x/evm/errors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/errors.go#L77-L79 

Added lines #L77 - L79 were not covered by tests

Check warning on line 87 in x/evm/errors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/errors.go#L81-L87 

Added lines #L81 - L87 were not covered by tests

Check warning on line 106 in x/evm/evmtest/erc20.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/erc20.go#L104-L106 

Added lines #L104 - L106 were not covered by tests

Check warning on line 130 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L128-L130 

Added lines #L128 - L130 were not covered by tests

Check warning on line 170 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L170 

Added line #L170 was not covered by tests

Check warning on line 251 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L249-L251 

Added lines #L249 - L251 were not covered by tests

Check warning on line 257 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L255-L257 

Added lines #L255 - L257 were not covered by tests

Check warning on line 279 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L279 

Added line #L279 was not covered by tests

Check warning on line 291 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L291 

Added line #L291 was not covered by tests

Check warning on line 72 in x/evm/precompile/funtoken.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/funtoken.go#L71-L72 

Added lines #L71 - L72 were not covered by tests

Check warning on line 75 in x/evm/precompile/funtoken.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/funtoken.go#L74-L75 

Added lines #L74 - L75 were not covered by tests

Check warning on line 192 in x/evm/precompile/precompile.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/precompile.go#L191-L192 

Added lines #L191 - L192 were not covered by tests

Check warning on line 198 in x/evm/precompile/precompile.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/precompile.go#L196-L198 

Added lines #L196 - L198 were not covered by tests

Check warning on line 202 in x/evm/precompile/precompile.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/precompile.go#L201-L202 

Added lines #L201 - L202 were not covered by tests

Check warning on line 68 in x/evm/precompile/wasm.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/wasm.go#L67-L68 

Added lines #L67 - L68 were not covered by tests

Check warning on line 126 in x/evm/statedb/journal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/statedb/journal.go#L121-L126 

Added lines #L121 - L126 were not covered by tests

Check warning on line 131 in x/evm/statedb/journal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/statedb/journal.go#L130-L131 

Added lines #L130 - L131 were not covered by tests

Check warning on line 522 in x/evm/statedb/statedb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/statedb/statedb.go#L515-L522 

Added lines #L515 - L522 were not covered by tests

Check warning on line 543 in x/evm/statedb/statedb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/statedb/statedb.go#L536-L543 

Added lines #L536 - L543 were not covered by tests
View more details on Codecov