Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evm): commit temporary state on precompile start, avoiding bug stemming from uncommitted, dirty journal entries in the EVM StateDB #2086

Merged
merged 17 commits into from
Oct 24, 2024

Merge branch 'ud/evm-fix-state-not-committed-before-precompile' of ht…

62a1b5f
Select commit
Loading
Failed to load commit list.
Merged

fix(evm): commit temporary state on precompile start, avoiding bug stemming from uncommitted, dirty journal entries in the EVM StateDB #2086

Merge branch 'ud/evm-fix-state-not-committed-before-precompile' of ht…
62a1b5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 0s

64.44% (target 60.00%)

View this Pull Request on Codecov

64.44% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 59.21788% with 73 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (3199ae5) to head (62a1b5f).

Files with missing lines Patch % Lines
x/evm/statedb/statedb.go 25.00% 16 Missing and 2 partials ⚠️
x/evm/evmtest/tx.go 64.28% 12 Missing and 3 partials ⚠️
x/evm/errors.go 0.00% 10 Missing ⚠️
x/evm/precompile/precompile.go 58.33% 7 Missing and 3 partials ⚠️
x/evm/statedb/journal.go 20.00% 8 Missing ⚠️
x/evm/precompile/funtoken.go 57.14% 4 Missing and 2 partials ⚠️
x/evm/evmtest/erc20.go 25.00% 3 Missing ⚠️
x/evm/precompile/wasm.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
+ Coverage   63.99%   64.44%   +0.44%     
==========================================
  Files         270      270              
  Lines       21116    21182      +66     
==========================================
+ Hits        13513    13650     +137     
+ Misses       6664     6580      -84     
- Partials      939      952      +13     
Files with missing lines Coverage Δ
x/evm/evmtest/test_deps.go 100.00% <100.00%> (+8.33%) ⬆️
x/evm/keeper/erc20.go 77.29% <100.00%> (+0.50%) ⬆️
x/evm/keeper/grpc_query.go 80.48% <100.00%> (-0.04%) ⬇️
x/evm/logs.go 100.00% <ø> (ø)
x/evm/precompile/errors.go 63.33% <100.00%> (+9.16%) ⬆️
x/evm/precompile/oracle.go 54.00% <100.00%> (+4.81%) ⬆️
x/evm/statedb/state_object.go 98.47% <100.00%> (ø)
x/evm/evmtest/erc20.go 90.90% <25.00%> (+2.02%) ⬆️
x/evm/precompile/wasm.go 50.29% <86.95%> (+0.58%) ⬆️
x/evm/precompile/funtoken.go 42.50% <57.14%> (-2.04%) ⬇️
... and 5 more