Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e-wasm.yml): rm unused workflow #1723

Merged
merged 3 commits into from
Dec 18, 2023
Merged

ci(e2e-wasm.yml): rm unused workflow #1723

merged 3 commits into from
Dec 18, 2023

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Dec 18, 2023

Purpose / Abstract

The GH action defined in e2e-wasm.yaml has been silently failing for months
and showing a passing state without executing logic. I believe we originally
added it to verify that we wired in the x/wasm module properly from
github.com/CosmWasm/wasmd, but we test this in many ways now. For example,
there are e2e contract tests in x/tokenfactory using real smart contracts.

It's safe to delete this file because it wasn't even running.

Summary by CodeRabbit

  • Chores

    • Removed an unused continuous integration workflow to streamline the development process.
  • Documentation

    • Updated the CHANGELOG to reflect recent changes in the CI process.

@Unique-Divine Unique-Divine requested a review from a team as a code owner December 18, 2023 21:48
Copy link
Contributor

coderabbitai bot commented Dec 18, 2023

Warning

Rate Limit Exceeded

@Unique-Divine has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 15 minutes and 10 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 37ba7cf and b13f4c7.

Walkthrough

The latest update in the repository includes a single change that streamlines the CI process. A commit was made to the NibiruChain project, which involved the removal of an unused workflow file, specifically e2e-wasm.yml. This could indicate a cleanup effort or an optimization of the CI pipeline.

Changes

File Path Change Summary
.github/workflows/e2e-wasm.yml Removed unused CI workflow file

🐇
In the warren of code, a file's dismissed,
CI streamlined, with a flick and a twist.
Farewell e2e-wasm, your duty is done,
Commit #1721, and now we hop on! 🚀
🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 29e6900 and 37ba7cf.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

@Unique-Divine Unique-Divine merged commit 89fc489 into main Dec 18, 2023
7 checks passed
@Unique-Divine Unique-Divine deleted the realu/ci-wasm-e2e branch December 18, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant