-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove temp directory caching which causes stale libs #1721
Conversation
WalkthroughThe Dockerfile has been updated to remove a specific cache mount from a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- contrib/docker/chaosnet.Dockerfile (1 hunks)
Additional comments: 2
contrib/docker/chaosnet.Dockerfile (2)
- 8-13: The hunk does not show the removal of the
--mount=type=cache,target=/nibiru/temp
directive as described in the PR objective and AI-generated summary. It's important to ensure that the correct line has been removed from the Dockerfile to address the caching issue. If the line has been removed as intended, this change is not reflected in the provided hunk and should be verified in the full file diff.Verification successful
The absence of output from the
rg
command indicates that the search pattern--mount=type=cache,target=/nibiru/temp
is not present in thecontrib/docker/chaosnet.Dockerfile
, which aligns with the PR objective of removing this cache mount directive to prevent the use of stale libraries.Based on the results of the shell script execution, it can be concluded that the directive has been successfully removed from the Dockerfile as intended in the pull request.
* 9-11: The cache directives for `/root/.cache/go-build` and `/go/pkg` remain in the Dockerfile. These are standard caching locations for Go builds and are presumably unaffected by the removal of the `/nibiru/temp` cache. It's important to confirm that these cache locations do not introduce similar issues as the one described for `/nibiru/temp`.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the `--mount=type=cache,target=/nibiru/temp` directive has been removed from the Dockerfile. rg --type dockerfile -- '-mount=type=cache,target=/nibiru/temp' contrib/docker/chaosnet.DockerfileLength of output: 133
Script:
#!/bin/bash # Verify that the `--mount=type=cache,target=/nibiru/temp` directive has been removed from the Dockerfile. rg '--mount=type=cache,target=/nibiru/temp' contrib/docker/chaosnet.DockerfileLength of output: 511
Script:
#!/bin/bash # Verify that the `--mount=type=cache,target=/nibiru/temp` directive has been removed from the Dockerfile. rg -e '--mount=type=cache,target=/nibiru/temp' contrib/docker/chaosnet.DockerfileLength of output: 81
Description
Remotes the
/nibiru/temp
cache directory.Purpose
Caching the
temp
directory causes the wrong version of the library to used, which is especially bad when we do multi-platform builds. For example, this run was broken because an incompatible libwasmvm was cached.Summary by CodeRabbit