Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove temp directory caching which causes stale libs #1721

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Dec 18, 2023

Description

Remotes the /nibiru/temp cache directory.

Purpose

Caching the temp directory causes the wrong version of the library to used, which is especially bad when we do multi-platform builds. For example, this run was broken because an incompatible libwasmvm was cached.

Summary by CodeRabbit

  • Refactor
    • Improved the Docker image build process by optimizing cache usage.

Copy link
Contributor

coderabbitai bot commented Dec 18, 2023

Walkthrough

The Dockerfile has been updated to remove a specific cache mount from a RUN command. This alteration likely affects the caching mechanism during the Docker image build process, with potential implications for build performance or the handling of temporary data.

Changes

File Summary
contrib/docker/.../chaosnet.Dockerfile Removed cache mount from RUN command

🐰✨
Changes in the code, oh so slight,
A Docker build, now less a plight.
Cache away, no longer bound,
Speedy builds, soon to astound. 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@k-yang k-yang self-assigned this Dec 18, 2023
@k-yang k-yang marked this pull request as ready for review December 18, 2023 18:45
@k-yang k-yang requested a review from a team as a code owner December 18, 2023 18:45
@k-yang k-yang merged commit 8515bc0 into main Dec 18, 2023
11 of 12 checks passed
@k-yang k-yang deleted the ci/chaosnet/remove-temp-cache branch December 18, 2023 18:45
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c420797 and 92a54aa.
Files selected for processing (1)
  • contrib/docker/chaosnet.Dockerfile (1 hunks)
Additional comments: 2
contrib/docker/chaosnet.Dockerfile (2)
  • 8-13: The hunk does not show the removal of the --mount=type=cache,target=/nibiru/temp directive as described in the PR objective and AI-generated summary. It's important to ensure that the correct line has been removed from the Dockerfile to address the caching issue. If the line has been removed as intended, this change is not reflected in the provided hunk and should be verified in the full file diff.
Verification successful

The absence of output from the rg command indicates that the search pattern --mount=type=cache,target=/nibiru/temp is not present in the contrib/docker/chaosnet.Dockerfile, which aligns with the PR objective of removing this cache mount directive to prevent the use of stale libraries.

Based on the results of the shell script execution, it can be concluded that the directive has been successfully removed from the Dockerfile as intended in the pull request.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that the `--mount=type=cache,target=/nibiru/temp` directive has been removed from the Dockerfile.
rg --type dockerfile -- '-mount=type=cache,target=/nibiru/temp' contrib/docker/chaosnet.Dockerfile

Length of output: 133



Script:

#!/bin/bash
# Verify that the `--mount=type=cache,target=/nibiru/temp` directive has been removed from the Dockerfile.
rg '--mount=type=cache,target=/nibiru/temp' contrib/docker/chaosnet.Dockerfile

Length of output: 511



Script:

#!/bin/bash
# Verify that the `--mount=type=cache,target=/nibiru/temp` directive has been removed from the Dockerfile.
rg -e '--mount=type=cache,target=/nibiru/temp' contrib/docker/chaosnet.Dockerfile

Length of output: 81

* 9-11: The cache directives for `/root/.cache/go-build` and `/go/pkg` remain in the Dockerfile. These are standard caching locations for Go builds and are presumably unaffected by the removal of the `/nibiru/temp` cache. It's important to confirm that these cache locations do not introduce similar issues as the one described for `/nibiru/temp`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

2 participants