Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dynamic table #612

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

Refactor dynamic table #612

wants to merge 36 commits into from

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 2, 2024

Motivation

PR #543 (Convert Azure Pipelines to GitHub actions) contained several changes to the dynamic table interface. In order to keep a clear separation of concerns, I wanted to separate all code changes related to dynamic table refactoring into a separate (this) PR.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

lawrence-mbf and others added 30 commits September 8, 2023 12:06
- properly embed bash calls
- fix artifact reference name
- try to fix MATLAB test discovery
- pull out class name function call
- refactor vararg column to make it more compatible with older MATLAB
  versions.
- Add data depth function which is reused by other functions.
Use version of MATLAB that supports hdf5 dynamically loaded filters.
- Change function arguments for addTableColumn to now support ragged
  Vector Indices
@ehennestad
Copy link
Collaborator Author

@lawrence-mbf Would you mind giving a brief overview of the motivation for the changes in this PR?

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 85.83333% with 34 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (6717aa1) to head (07b746d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
+types/+util/+dynamictable/addVarargColumn.m 73.17% 22 Missing ⚠️
+types/+util/getVectorClassName.m 60.86% 9 Missing ⚠️
+types/+util/+dynamictable/addColumn.m 94.44% 1 Missing ⚠️
+types/+util/+dynamictable/addRawData.m 92.30% 1 Missing ⚠️
+types/+util/+dynamictable/getIndex.m 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   90.63%   90.18%   -0.46%     
==========================================
  Files         106      107       +1     
  Lines        4689     4767      +78     
==========================================
+ Hits         4250     4299      +49     
- Misses        439      468      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants