-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dynamic table #612
Draft
ehennestad
wants to merge
36
commits into
master
Choose a base branch
from
refactor/dynamic-table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- properly embed bash calls - fix artifact reference name - try to fix MATLAB test discovery
- pull out class name function call - refactor vararg column to make it more compatible with older MATLAB versions. - Add data depth function which is reused by other functions.
Use version of MATLAB that supports hdf5 dynamically loaded filters.
- Change function arguments for addTableColumn to now support ragged Vector Indices
…ithoutBorders/matnwb into convert-ci-to-actions
…ithoutBorders/matnwb into convert-ci-to-actions
ehennestad
added a commit
that referenced
this pull request
Nov 2, 2024
@lawrence-mbf Would you mind giving a brief overview of the motivation for the changes in this PR? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 90.63% 90.18% -0.46%
==========================================
Files 106 107 +1
Lines 4689 4767 +78
==========================================
+ Hits 4250 4299 +49
- Misses 439 468 +29 ☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #543 (Convert Azure Pipelines to GitHub actions) contained several changes to the dynamic table interface. In order to keep a clear separation of concerns, I wanted to separate all code changes related to dynamic table refactoring into a separate (this) PR.
Checklist
fix #XX
whereXX
is the issue number?