Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Azure Pipeline to Github Actions #543

Merged
merged 50 commits into from
Nov 2, 2024
Merged

Conversation

lawrence-mbf
Copy link
Collaborator

@lawrence-mbf lawrence-mbf commented Sep 8, 2023

Motivation

Better future integration with Github Pages

  • Badge generation

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Test Results

77 tests   77 ✔️  5m 2s ⏱️
21 suites    0 💤
  1 files      0

Results for commit e1d091a.

♻️ This comment has been updated with latest results.

- pull out class name function call
- refactor vararg column to make it more compatible with older MATLAB
  versions.
- Add data depth function which is reused by other functions.
Use version of MATLAB that supports hdf5 dynamically loaded filters.
- Change function arguments for addTableColumn to now support ragged
  Vector Indices
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.56%. Comparing base (3be8111) to head (36a55ef).

Files with missing lines Patch % Lines
tools/maintenance/validateCodecovSettings.m 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   90.63%   90.56%   -0.08%     
==========================================
  Files         106      107       +1     
  Lines        4689     4695       +6     
==========================================
+ Hits         4250     4252       +2     
- Misses        439      443       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad marked this pull request as ready for review November 1, 2024 20:27
@ehennestad ehennestad marked this pull request as draft November 2, 2024 08:04
@ehennestad ehennestad mentioned this pull request Nov 2, 2024
3 tasks
@ehennestad ehennestad marked this pull request as ready for review November 2, 2024 11:03
@ehennestad
Copy link
Collaborator

@bendichter

  1. I made a separate PR (Refactor dynamic table #612 ) for changes that were included in this PR but were not relevant to it.
  2. This PR brings with it a lot of "junk" commits, I suggest to squash merge

@ehennestad ehennestad merged commit 5cd6af6 into master Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants