Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an unformatted version of an example as a regression test #160

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

sanjayankur31
Copy link
Member

This is to check jLEMS parses unformatted LEMS files correctly.

Reference: LEMS/jLEMS#95

This is to check jLEMS parses unformatted LEMS files correctly.

Reference: LEMS/jLEMS#95
@sanjayankur31 sanjayankur31 self-assigned this Jun 15, 2021
@sanjayankur31 sanjayankur31 added C: NeuroML software C: NeuroML software S: ready Status: ready T: enhancement Type: enhancement labels Jun 15, 2021
@pgleeson
Copy link
Member

Sure, but maybe put it in a subfolder, to avoid confusion?

@sanjayankur31
Copy link
Member Author

Ideally we should have a folder for tests---we're just running all the examples at the moment as tests. Should I create a "tests" in the "example" folder for the time being?

sanjayankur31 added a commit to NeuroML/jNeuroML that referenced this pull request Jun 25, 2021
It was moved to a different sub-folder in
NeuroML/NeuroML2#160
@pgleeson pgleeson merged commit 232280e into development Jun 25, 2021
@pgleeson pgleeson deleted the feat/add-lems-regression-test branch May 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: NeuroML software C: NeuroML software S: ready Status: ready T: enhancement Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants