Fix parser logic #95
Merged
Fix parser logic #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two tags are closed successively, for example:
`</OutputFile></Simulation>`, the pointer `iwk` should be moved forward
only by `tg.length() + 1` so that it arrives on the next `<`:
```
IWK
|
</OutputFile></Simulation>
IWK
|
</OutputFile></Simulation>
```
If it is moved by `tg.length() + 2`, it misses the `<` and so does not
recognise the next tag at all.
Fixes NeuroML/jNeuroML#2
Fixes NeuroML/pyNeuroML#100
Fixes LEMS#40
sanjayankur31
added a commit
to NeuroML/NeuroML2
that referenced
this pull request
Jun 15, 2021
This is to check jLEMS parses unformatted LEMS files correctly. Reference: LEMS/jLEMS#95
sanjayankur31
added a commit
to NeuroML/jNeuroML
that referenced
this pull request
Jun 15, 2021
pgleeson
reviewed
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.