fix: use I prefix for interfaces
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostridm
added
the
Type: maintenance
|
Code Climate has analyzed commit 76d87bc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.1%. View more on Code Climate. |
derevnjuk
changed the title
I prefix for each interfaceI prefix for interfaces
ostridm
force-pushed
the
chore_#135/interface-naming-reconciliation
branch
from
dfa799c
to
0f08c3a
Compare
derevnjuk
requested changes
Dec 14, 2022
derevnjuk
added
Type: technical debt
derevnjuk
changed the title
I prefix for interfacesI prefix for interfaces
ostridm
added a commit
that referenced
this pull request
Dec 14, 2022
… constructor adjust according to code review #136 (comment) #136 (comment) closes #135
ostridm
force-pushed
the
chore_#135/interface-naming-reconciliation
branch
from
0f08c3a
to
8194c82
Compare
…uctor adjust according to code review #136 (comment) #136 (comment) closes #135
ostridm
force-pushed
the
chore_#135/interface-naming-reconciliation
branch
from
8194c82
to
76d87bc
Compare
derevnjuk
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135