Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface naming reconciliation #135

Closed
ostridm opened this issue Dec 14, 2022 · 0 comments · Fixed by #136
Closed

Interface naming reconciliation #135

ostridm opened this issue Dec 14, 2022 · 0 comments · Fixed by #136
Assignees
@ostridm
Labels
Type: technical debt Changes that remove or significantly update old unused code and/or dependencies.

Comments

@ostridm
Copy link
Contributor

ostridm commented Dec 14, 2022

Introduce I prefix for each interface in repository e.g. SacnFactory → IScanFactory
@ostridm ostridm added the Type: maintenance The issues that touch on functional checks, servicing or supporting of customers label Dec 14, 2022
@ostridm ostridm self-assigned this Dec 14, 2022
ostridm added a commit that referenced this issue Dec 14, 2022
@ostridm
chore(*): introduce I prefix for each interface
b042dbe 
closes #135
@ostridm ostridm mentioned this issue Dec 14, 2022
Merged
@derevnjuk derevnjuk added Type: technical debt Changes that remove or significantly update old unused code and/or dependencies. and removed Type: maintenance The issues that touch on functional checks, servicing or supporting of customers labels Dec 14, 2022
ostridm added a commit that referenced this issue Dec 14, 2022
@ostridm
chore(*): update interface names in doc
8e8e7f4 
closes #135
ostridm added a commit that referenced this issue Dec 14, 2022
@ostridm
chore(*): declare IConfigurationOptions and Configuration convenience…
dfa799c 
… constructor

closes #135
ostridm added a commit that referenced this issue Dec 14, 2022
@ostridm
chore(*): declare IConfigurationOptions and Configuration convenience…
0f08c3a 
… constructor

closes #135
ostridm added a commit that referenced this issue Dec 14, 2022
@ostridm
chore(*): declare IConfigurationOptions and Configuration convenience…
8194c82 
… constructor

adjust according to code review
#136 (comment)
#136 (comment)

closes #135
ostridm added a commit that referenced this issue Dec 14, 2022
@ostridm
chore(*): declare IConfiguration and Configuration convenience constr…
76d87bc 
…uctor

adjust according to code review
#136 (comment)
#136 (comment)

closes #135
derevnjuk pushed a commit that referenced this issue Dec 14, 2022
@ostridm
fix: use I prefix for interfaces (#136)
851b522 
closes #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ostridm ostridm

Labels
Type: technical debt Changes that remove or significantly update old unused code and/or dependencies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use I prefix for interfaces NeuraLegion/sectester-net
2 participants
@ostridm @derevnjuk