refactor: replace external(v0) by abi(embed_v0)

[enitrat]

Issue(s): close #125

Description

• see title
• fixed wrong casing conventions in cheat sheet contracts (by the way, the relevancy of this section is not super obvious to me, but I guess the more the better)
• removed implicit interfaces (no longer possible - embedded interfaces can only be implementations of a starknet::interface trait)

Checklist

• CI Verifier: Run cairo_programs_verifier successfully
• Contract Tests: Added tests to cover the changes
• Remix Link: Added a link to open the contract in Remix
• Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

[julio4]

LGTM, I just have some concerns about implicit/explicit interfaces. Thank you for taking the time to correct these issues!

About the Cheatsheet part: The idea was to have ultra concise example about common patterns (such as loop, match, type casting, ...) that new Cairo developers could refers to quickly remember the correct syntax.

[enitrat]

About the Cheatsheet part: The idea was to have ultra concise example about common patterns (such as loop, match, type casting, ...) that new Cairo developers could refers to quickly remember the correct syntax.

As Cairo is not just a SC language it makes no sense to me why these would be presented inside contracts 🤔 It just introduces un-necessary boilerplate over what's actually important

[julio4]

About the Cheatsheet part: The idea was to have ultra concise example about common patterns (such as loop, match, type casting, ...) that new Cairo developers could refers to quickly remember the correct syntax.

As Cairo is not just a SC language it makes no sense to me why these would be presented inside contracts 🤔 It just introduces un-necessary boilerplate over what's actually important

I understand your concerns and mostly agree, it's a bit out of scope for contracts, but still in the philosophy of by example. I received some feedback that these quick references are helpful for beginners. Maybe we should move it to something similar in the Cairo Book instead?

We can continue the discussion in #102 if you want.

[julio4]

LGTM! Thank you!

[enitrat]

I think it could stay there but just not wrapped inside a contract 🤔

[julio4]

I think it could stay there but just not wrapped inside a contract 🤔

Hum I agree with you on that. It will be addressed soon.