Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[external(v0)] soon deprecated #125

Closed
enitrat opened this issue Nov 25, 2023 · 2 comments · Fixed by #126
Closed

#[external(v0)] soon deprecated #125

enitrat opened this issue Nov 25, 2023 · 2 comments · Fixed by #126
Assignees
@enitrat

Comments

@enitrat
Copy link
Collaborator

enitrat commented Nov 25, 2023

We should replace it by #[abi(embed_v0)]
@enitrat enitrat self-assigned this Nov 25, 2023
@enitrat enitrat mentioned this issue Nov 25, 2023
Merged
4 tasks
@julio4
Copy link
Contributor

julio4 commented Nov 26, 2023

#91 for reference.
Actually I'm not sure that #[external(v0)] will be deprecated at function level but only at block implementation level.
We should be able to still use #[external(v0)] in #[abi(per_items)] from my understanding.

@julio4 julio4 mentioned this issue Nov 26, 2023
Merged
4 tasks
@enitrat
Copy link
Collaborator Author

enitrat commented Nov 26, 2023

yes indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enitrat enitrat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace external(v0) by abi(embed_v0) NethermindEth/StarknetByExample
2 participants
@julio4 @enitrat