-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unsubscription of HystrixCommands #1204
Conversation
👍 |
…in the request-cache and the loser needs to get cleaned up (unsubscribed)
Thanks @stevegury. Just modified the state in |
👍 |
…race request-cache insert
I think the implementation of com.netflix.hystrix.HystrixCommand.queue() is still not compliant with Future.cancel(boolean) as it does not seem to interrupt the execution thread. |
I just created a new issue to track making this work properly: #1268 |
This is a large reorganization of Hystrix internals to support unsubscription.
The changes are:
Observable.create
I've added a number of tests to check unsubscription. Outstanding work: