Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hystrix Command should be cancellable #220

Closed
panterose opened this issue Mar 13, 2014 · 4 comments
Closed

Hystrix Command should be cancellable #220

panterose opened this issue Mar 13, 2014 · 4 comments

Comments

@panterose
Copy link

At the moment, if you call .queue() on a command and get a future, you cannot call the cancel() method and abort its execution. This is true for the current 1.3.XX version (it seems to work if you don't use the cache for some reason) but also in the upcoming 1.4 version.

I can supply a reduced code sample if needed, but it's very easy to reproduced. It's an issue for me as we have some long running command.

We also have the case where we encapsulate child command inside main command, ideally the cancel() should be cascading.

@benjchristensen
Copy link
Contributor

I think I know what is causing this, it's the decoupling done by the Subject used because caching necessitates multicasting. I'll need to think about supporting multicasting and unsubscribe at the same time.

@benjchristensen benjchristensen added this to the 1.4.x milestone Dec 12, 2014
@benjchristensen
Copy link
Contributor

Putting into 1.4.x to consider, but this remains a tricky thing when caching is supported. It would have to behave like Subject.refCount() where it only cancels the original HystrixCommand if all consumers cancel/unsubscribe.

@mattrjacobs mattrjacobs removed this from the 1.4.x milestone Dec 19, 2014
@panterose panterose removed this from the 1.4.x milestone Dec 19, 2014
@mattrjacobs mattrjacobs added this to the 1.4.0-RC7 milestone Dec 19, 2014
@mattrjacobs
Copy link
Contributor

Talked to @benjchristensen about this. Since the semantics are slightly different than Subject.refCount(), it will take some time/care to do this properly. As a result, targeting this for 1.4 series, but not gating RC7 on it.

@mattrjacobs mattrjacobs modified the milestones: 1.4.x, 1.4.0-RC7 Jan 29, 2015
@mattrjacobs mattrjacobs removed this from the 1.4.x milestone Aug 3, 2015
@mattrjacobs
Copy link
Contributor

This is fixed in #1204. Will be released in 1.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants