Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move jest-cli to peerDependencies #32

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Move jest-cli to peerDependencies #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Gulp plugin for the Jest test library
## Installation

```bash
$ npm install gulp-jest
$ npm install gulp-jest jest-cli
```

## Usage
Expand Down
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,20 @@
},
"homepage": "https://github.com/alansouzati/gulp-jest",
"dependencies": {
"jest-cli": "^17.0.0",
"gulp-util": "^3.0.0",
"through2": "^2.0.1"
},
"devDependencies": {
"babel-cli": "^6.18.0",
"babel-jest": "^17.0.0",
"babel-jest": ">=17.0.0",
"babel-plugin-transform-object-rest-spread": "^6.3.13",
"babel-preset-es2015": "^6.1.18",
"babel-preset-react": "^6.1.18",
"gulp": "^3.8.7"
"gulp": "^3.8.7",
"jest-cli": ">=17.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to declare jest-cli in both devDependencies and peerDependencies?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you explain the motivation behind moving from ^ to >= ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's declared in devDependencies because without it the tests would fail. 😉

And again, => means any version 17 or above is good. In the unlikely case where Jest introduces a breaking change to its public CLI interface, you can publish a patch release with an upper bound e.g. =>17.0.0 < 19.5.0, fix the issue, then release a major version with a new lower bound. Hope this makes sense.

},
"peerDependencies": {
"jest-cli": ">=17.0.0"
},
"keywords": [
"gulpplugin",
Expand Down