Move jest-cli to peerDependencies #32
Conversation
|
@alansouzati It'd be great if you could cut a new release when if you merge this. Happy Holidays! 🎄 |
|
Thanks for your contribution. Can you add details around the motivation to move to peerDependencies? |
| "babel-plugin-transform-object-rest-spread": "^6.3.13", | ||
| "babel-preset-es2015": "^6.1.18", | ||
| "babel-preset-react": "^6.1.18", | ||
| "gulp": "^3.8.7" | ||
| "gulp": "^3.8.7", | ||
| "jest-cli": ">=17.0.0" |
There was a problem hiding this comment.
why we need to declare jest-cli in both devDependencies and peerDependencies?
There was a problem hiding this comment.
Also, can you explain the motivation behind moving from ^ to >= ?
There was a problem hiding this comment.
It's declared in devDependencies because without it the tests would fail. 😉
And again, => means any version 17 or above is good. In the unlikely case where Jest introduces a breaking change to its public CLI interface, you can publish a patch release with an upper bound e.g. =>17.0.0 < 19.5.0, fix the issue, then release a major version with a new lower bound. Hope this makes sense.
|
@alansouzati Because the version of Jest I use should not be dictated by a gulp plugin. More on peerDependencies here. |
|
Thanks for clarifying, yes it definitely makes sense. Again, thanks for your contribution! And happy new year! |
|
I've released gulp-jest 1.0.0. I assumed it was a breaking change as now we don't provide jest-cli out of the box. |
🍺