Remove four argument mul! for ZZMatrix

[fingolfin]

Remove four argument mul! for ZZMatrix. The fourth argument was a Bool, which if set to true would basically perform an addmul! (except that we don't have addmul! for matrices right now...).

This code was introduced by @fieker so pinging him in case he remembers what it was for.

I also made Nemocas/AbstractAlgebra.jl#1801 which once merged and released should produce identical results for ZZMatrix inputs.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.25%. Comparing base (4d25cd4) to head (9eafea2).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1857      +/-   ##
==========================================
+ Coverage   86.21%   86.25%   +0.03%     
==========================================
  Files          99       99              
  Lines       36030    36027       -3     
==========================================
+ Hits        31064    31075      +11     
+ Misses       4966     4952      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lgoettgens]

We should merge for downstream tests working again before merging this

[fieker]

On Thu, Sep 19, 2024 at 07:13:54AM -0700, Max Horn wrote: Remove four argument `mul!` for `ZZMatrix`. The fourth argument was a `Bool`, which if set to `true` would basically perform an `addmul!` (except that we don't have `addmul!` for matrices right now...). This code was introduced by @fieker so pinging him in case he remembers what it was for.

It's crucial for Strassen multiplication and compatibility with BLAS

…

I also made Nemocas/AbstractAlgebra.jl#1801 which once merged and released should produce identical results for `ZZMatrix` inputs. You can view, comment on, or merge this pull request online at: #1857 -- Commit Summary -- * Remove four argument mul! for ZZMatrix -- File Changes -- M src/flint/fmpz_mat.jl (13) -- Patch Links -- https://github.com/Nemocas/Nemo.jl/pull/1857.patch https://github.com/Nemocas/Nemo.jl/pull/1857.diff -- Reply to this email directly or view it on GitHub: #1857 You are receiving this because you were mentioned. Message ID: ***@***.***>

[lgoettgens]

We (@thofma and I) may have already broken the generic version of this in AA. I'll look into it tomorrow

[thofma]

@fieker I have not found it in https://github.com/Nemocas/AbstractAlgebra.jl/blob/0f401540af7cf9d0b7880e13e8766700c0e65d0d/src/Matrix-Strassen.jl#L3

[lgoettgens]

@fieker I have not found it in https://github.com/Nemocas/AbstractAlgebra.jl/blob/0f401540af7cf9d0b7880e13e8766700c0e65d0d/src/Matrix-Strassen.jl#L3

As I wrote above, I have probably messed this up...

[lgoettgens]

Strassen is broken in AA v0.43.1. Nemocas/AbstractAlgebra.jl#1803 will revive it again, but then it does not need this four-argument mul! anymore.
So in any case, we can remove it.

[fingolfin]

@lgoettgens you enabled and then disabled auto-squash. Just wondering if there are any remaining concerns, or was this just an accident?

[lgoettgens]

Just instable internet on the train