Make addmul! fully generic, add docstrings #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can e.g. use addmul! on 3 or 4 ZZMatrix instances and get an efficient result. Use this to get rid of some now redundant `addmul!` methods. Also remove some redundant `add!` methods and add some `sub!` methods.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
=======================================
Coverage 87.99% 88.00%
=======================================
Files 119 119
Lines 30073 30060 -13
=======================================
- Hits 26464 26454 -10
+ Misses 3609 3606 -3 ☔ View full report in Codecov by Sentry. |
lgoettgens
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Looks good, but we should wait for downstream tests to confirm (once oscar-system/Oscar.jl#4122 is merged)
|
Downstream tests ran and it looks good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can e.g. use addmul! on 3 or 4 ZZMatrix instances and get an efficient result.
Use this to get rid of some now redundant
addmul!methods.Also remove some redundant
add!methods and add somesub!methods.