Make global variables const #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 117 117
Lines 29919 29919
=======================================
+ Hits 26147 26148 +1
+ Misses 3772 3771 -1 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Jul 15, 2024
| moduli7 = [8, 29, 43] | ||
| residues7 = [[0, 1, 3, 5, 7], [0, 1, 12, 17, 28], [0, 1, 6, 7, 36, 37, 42]] | ||
| const moduli7 = [8, 29, 43] | ||
| const residues7 = [[0, 1, 3, 5, 7], [0, 1, 12, 17, 28], [0, 1, 6, 7, 36, 37, 42]] |
There was a problem hiding this comment.
I was curious what these vectors are used for. Turns put the code is buggy: the code in line 391 below checks for divisibility by 3 instead of 7... oops.
There was a problem hiding this comment.
I am also confused by the mix of % and mod. Can you provide a PR fixing this function or make an issue so we don't forget?
There was a problem hiding this comment.
I only have my phone right now
fingolfin
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance type inference