Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in ispower_moduli? #1750

Closed
lgoettgens opened this issue Jul 15, 2024 · 1 comment · Fixed by #1772
Closed

Bugs in ispower_moduli? #1750

lgoettgens opened this issue Jul 15, 2024 · 1 comment · Fixed by #1772

Comments

@lgoettgens
Copy link
Collaborator

lgoettgens commented Jul 15, 2024

I was curious what these vectors are used for. Turns put the code is buggy: the code in line 391 below checks for divisibility by 3 instead of 7... oops.

Originally posted by @fingolfin in #1749 (comment)

@lgoettgens lgoettgens changed the title Bugs in ispower_moduli Bugs in ispower_moduli? Jul 16, 2024
@fingolfin
Copy link
Member

I suspect the code is still correct but perhaps less efficient.

The lack of any comments explaining what's going on (which admittedly is not that hard to guess) or more importantly, why those specific numbers have been chosen, doesn't help :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants