Fix one diagonal_matrix dispatch
#1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
- Coverage 84.75% 84.69% -0.07%
==========================================
Files 110 110
Lines 29354 29356 +2
==========================================
- Hits 24878 24862 -16
- Misses 4476 4494 +18
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that #1438 was in fact breaking for https://github.com/thofma/Hecke.jl/blob/75dbabf5ab7c863bba8fc233a85583b674211554/src/QuadForm/Quad/ZGenus.jl#L1600 in Hecke, as it removed the possibility to use
diagonal_matrix(::NCRing, ::Vector{<:MatElem})with empty list of blocks.Thus, currently, Hecke master's CI is broken (but there have been no runs yet). I thus would like to have this patch here released shortly.