Skip to content

Commit

Permalink
Fix one diagonal_matrix dispatch (#1448)
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens authored Sep 26, 2023
1 parent 5891cfa commit 180b6d3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "AbstractAlgebra"
uuid = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
version = "0.32.2"
version = "0.32.3"

[deps]
GroupsCore = "d5909c97-4eac-4ecc-a3dc-fdd0858a4120"
Expand Down
6 changes: 5 additions & 1 deletion src/Matrix.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7019,7 +7019,11 @@ function diagonal_matrix(x::T, xs::T...) where {T<:MatElem}
end

function diagonal_matrix(R::NCRing, V::Vector{<:MatElem})
return block_diagonal_matrix(map(x -> change_base_ring(R, x), V))
if length(V) == 0
return zero_matrix(R, 0, 0)
else
return block_diagonal_matrix(map(x -> change_base_ring(R, x), V))
end
end


Expand Down

2 comments on commit 180b6d3

@thofma
Copy link
Member

@thofma thofma commented on 180b6d3 Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/92252

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.32.3 -m "<description of version>" 180b6d35395cfc351f4aa14f5b792b8bcfc17eb2
git push origin v0.32.3

Please sign in to comment.