-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow design-grid resolution to accept a tuple #2599
Allow design-grid resolution to accept a tuple #2599
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #2599 +/- ##
==========================================
- Coverage 73.90% 73.81% -0.09%
==========================================
Files 18 18
Lines 5293 5294 +1
==========================================
- Hits 3912 3908 -4
- Misses 1381 1386 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to include a unit test for this feature. One suggestion would be to simply verify that defining a filter with the resolution tuple (res, res)
produces the same result as passing in just res
.
1b59762
to
6c94f35
Compare
I have added a different but more stringent test, in which one of the elements of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR allows the
resolution
argument in filters.py to accept a tuple, so that different resolutions along different directions can be supported. This PR also refactors the code in filters.py.