Remove unnecessary long-duration source from LED extraction-efficiency tutorial in cylindrical coordinates #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y tutorial in cylindrical coordinates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2382 and #2383 fixed two separate bugs related to the$z$ -PML at $r=0$ for $m=0, \pm 1$ simulation in cylindrical coordinates. Prior to this bugfix, to ensure that the fields at $r=0$ decayed sufficiently away it was necessary to use the workaround of a narrow bandwidth source with long cutoff. However, this long-duration source is no longer necessary for these types of calculations.
This PR updates the tutorial Extraction Efficiency of a Light-Emitting Diode (LED) to replace this long-duration source with a significantly shorter one.