Fix bug in step-db update equations in cylindrical coordinates for m=±1
#2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2023
radiated flux from $E_r$ point source at $r=0$ in cylindrical coordinates depends on cell size
#2338
Closed
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the field update equations in cylindrical coordinates for
m = ±1described in #2108 (comment).Also includes a new unit test which verifies that the radiated flux from a point source is the same for simulations with
m = ±1. This is based on the discussion in #2108 (comment).Since this bug fix also fixes the$z$ -PML at $r=0$ which previously required using a large
cutoffvalue for theGaussianSourceas described in #2148 (comment), the existing unit test intest_ldos_ext_effoftest_ldos.pyis also updated to remove the largecutoffparameter from the source.