Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

How does one make a list become privileged? #231

Closed
DandelionSprout opened this issue Nov 27, 2018 · 6 comments
Closed

How does one make a list become privileged? #231

DandelionSprout opened this issue Nov 27, 2018 · 6 comments
Labels
archived This thread was archived, open new issues for similar problems. fixed

Comments

@DandelionSprout
Copy link

DandelionSprout commented Nov 27, 2018

I'm trying to get this list to become a privileged list. As it's constructed out of some entries that are currently exclusive to the browser extension version of I Don't Care About Cookies, it uses nanop-easy-set-cookie.js extensively, but the entries currently aren't loaded from the list when I import the list into Nano Adblocker.

As such, how do I make a list become privileged in Nano? Bonus points if the list maker can make it privileged for all users of it, as opposed to having it be done on the client-side.

@jspenguin2017
Copy link
Member

jspenguin2017 commented Nov 27, 2018

The author of the list (which is you?) need to apply for it by opening an issue here.

To test it locally, you can make user filters privileged: https://github.com/NanoAdblocker/NanoDoc/blob/master/en/AdvancedSettings.MD#nanomakeuserfiltersprivileged-switch

@jspenguin2017
Copy link
Member

jspenguin2017 commented Nov 27, 2018

Make sure to test your rules though, extensions are still way more powerful than privileged script snippets.

@DandelionSprout
Copy link
Author

DandelionSprout commented Nov 27, 2018

While I am the author of that list, I did originally intend for IDCAC's creator (who my PayPal donation archive tells me is named Daniel Kladnik) to take over the ownership of that list or of a similar one, and to incorporate it into his main list somehow.

So I figured that for all parties involved, I thought it'd be easier for both me and him to create and test various sandbox lists if there was a way to make them privileged, that didn't depend on applications and Nano updates.

Given that he does indeed have an extension that he maintains and prefers over his adblocker list, I'd be surprised if he'd want to deal all that much with extra lists and applications and such, especially if it takes a little extra bit of effort to do so.

I did succeed in setting nanoMakeUserFiltersPrivileged to true, but sadly that only applies to the "My filters" section.

I suppose that now that you have explained the official method for making a list privileged (By requesting you about it), that this issue can be closed, but I now think it'd be nice to give that a mention in https://github.com/NanoAdblocker/NanoDoc/blob/master/en/AdvancedSettings.MD#nanomakeuserfiltersprivileged-switch, for record's sake. 🙂

@jspenguin2017
Copy link
Member

jspenguin2017 commented Nov 27, 2018

I have to review each privileged filters, even if I don't hard code the whitelist, I'll probably still be the only one who can change it.

You should always test your rules with "My filters", as it also has a linter which should help with debugging. If you think another option that makes third-party filters privileged can be useful, you are welcomed to open another issue about it.

I will add more explanations to the doc.

@jspenguin2017
Copy link
Member

As a side note, the whitelist is currently hard coded here: https://github.com/NanoAdblocker/NanoCore2/blob/master/src/js/nano-background.js

jspenguin2017 added a commit to NanoAdblocker/NanoDoc that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoCore2 that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoCore2 that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoCore2 that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoCore2 that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoCore2 that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoCore2 that referenced this issue Nov 27, 2018
jspenguin2017 added a commit to NanoAdblocker/NanoDoc that referenced this issue Nov 27, 2018
@jspenguin2017
Copy link
Member

jspenguin2017 commented Nov 27, 2018

It's pretty easy to implement so why not... There is already userResourcesLocation which is 10 times more powerful.

nanoMakeThirdPartyFiltersPrivileged is now available (starting v1.0.0.79b1).
Doc: https://github.com/NanoAdblocker/NanoDoc/blob/master/en/AdvancedSettings.MD#nanomakethirdpartyfiltersprivileged-switch

@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. fixed
Projects
None yet
Development

No branches or pull requests

2 participants