Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Applying to get one of my newest lists trusted in Nano #266

Closed
DandelionSprout opened this issue May 15, 2019 · 4 comments
Closed

Applying to get one of my newest lists trusted in Nano #266

DandelionSprout opened this issue May 15, 2019 · 4 comments
Labels
archived This thread was archived, open new issues for similar problems. question

Comments

@DandelionSprout
Copy link

Related to #231, I have now after 6 months promoted that particular list of mine from Sandbox status to fulltime list status. Thus I hereby request for https://raw.githubusercontent.com/DandelionSprout/adfilt/master/IDCACnano.txt to become trusted by default in Nano Adblocker.

If accepted, this should probably also apply to its mirror links as well (GitLab, Repo.or.cz).

@DandelionSprout
Copy link
Author

DandelionSprout commented May 15, 2019

If needed for context, then here's the file from I Don't Care About Cookies's Firefox extension version that I took the entries from (although I had to change the file format from JSON to .txt to upload it to GitHub): common6.txt

@jspenguin2017
Copy link
Member

jspenguin2017 commented May 15, 2019

Privileged filter lists must be served from NanoFilters repository. Please, create a new folder named ThirdPartyPrivileged and send PRs to NanoFilters to register and update your privileged filter list.

Also, keep in mind that script snippets don't run on true document-start, so simply converting the rules may not be enough.

@DandelionSprout
Copy link
Author

I was able to get the list to work on archiveofourown and Twitter, and I have reason to assume that most of the non-functional entries are a result of how IDCAC's maintainer tries to waddle his way through a five-digit amount of user reports about unblocked cookie notifications, thus he rarely gets time to polish his existing entries.

I'll make a pull request any moment now.

@jspenguin2017
Copy link
Member

Alright, closing this in favor of the PR.

@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. question
Projects
None yet
Development

No branches or pull requests

2 participants