Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert frontend build script #614

Merged
merged 1 commit into from
May 2, 2023
Merged

Revert frontend build script #614

merged 1 commit into from
May 2, 2023

Conversation

bastienbeurier
Copy link
Member

Close #612

@khaliqgant khaliqgant self-requested a review May 2, 2023 07:58
@khaliqgant
Copy link
Member

Thanks @bastienbeurier. We should write on the original issue and reopen #385 with a note that resolution is blocked by facebook/create-react-app#11752

@bastienbeurier bastienbeurier mentioned this pull request May 2, 2023
Closed
@bastienbeurier bastienbeurier merged commit 5b9454f into master May 2, 2023
@bastienbeurier bastienbeurier deleted the fe-build-fix branch May 2, 2023 08:28
@bastienbeurier
Copy link
Member Author

Just did, thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaliqgant khaliqgant khaliqgant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPM install @nangohq/frontend is broken
2 participants
@bastienbeurier @khaliqgant