Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM install @nangohq/frontend is broken #612

Closed
rguldener opened this issue May 1, 2023 · 4 comments · Fixed by #614
Closed

NPM install @nangohq/frontend is broken #612

rguldener opened this issue May 1, 2023 · 4 comments · Fixed by #614
Labels
bug Something isn't working

Comments

@rguldener
Copy link
Member

Installing @nanghoq/frontend is broken. To reproduce:

robin@MacBook-Air ~ % mkdir test
robin@MacBook-Air ~ % npm i @nangohq/frontend
npm ERR! code 127
npm ERR! path /Users/robin/node_modules/@nangohq/frontend
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! > @nangohq/[email protected] build
npm ERR! > tsc --sourceMap
npm ERR! sh: tsc: command not found

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/robin/.npm/_logs/2023-05-01T20_25_24_563Z-debug-0.log
@rguldener rguldener added the bug Something isn't working label May 1, 2023
@rguldener
Copy link
Member Author

Looks like this change is causing it: c02b0fe

khaliqgant added a commit to khaliqgant/nango that referenced this issue May 2, 2023
bastienbeurier added a commit that referenced this issue May 2, 2023
bastienbeurier added a commit that referenced this issue May 2, 2023
@jesse-olympus
Copy link

@bastienbeurier This is broken in v0.16.0 as well. I recommend versioning the package separately from the fix commits

@bastienbeurier
Copy link
Member

@jesse-olympus I can't reproce the error. Just ran npm i @nangohq/frontend and is worked. Do you mind sharing more info? (e.g. logs)

@bastienbeurier
Copy link
Member

bastienbeurier commented May 8, 2023

@jesse-olympus Sorry actually the fix I did was not in the release. I've just released 0.16.1 that should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants