Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): exit 1 when compilation fail #2650

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix(cli): exit 1 when compilation fail #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0e494a
fix(cli): exit 1 when compilation fail
bodinsamuel Aug 29, 2024
9daaceb
ignore models.ts
bodinsamuel Aug 29, 2024
67b831b
Merge branch 'master' into fix/cli-exit-on-broken-compilation
bodinsamuel Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ program

const success = await compileAllFiles({ fullPath, debug });
if (!success) {
console.log(chalk.red('Compilation was not fully successful. Please make sure all files compile before deploying'));
process.exitCode = 1;
}
});
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/lib/services/compile.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ export async function compileAllFiles({
if (!completed) {
if (scriptName && file.inputPath.includes(scriptName)) {
success = false;
} else if (!scriptName && !file.inputPath.endsWith('models.ts')) {
success = false;
}
}
} catch (error) {
Expand Down Expand Up @@ -194,7 +196,6 @@ async function compile({
debug: boolean;
}): Promise<boolean> {
const providerConfiguration = getProviderConfigurationFromPath({ filePath: file.inputPath, parsed });

if (!providerConfiguration) {
return false;
}
Expand All @@ -203,7 +204,6 @@ async function compile({
const type = syncConfig?.type || 'sync';

const success = compileImportedFile({ fullPath, filePath: file.inputPath, compiler, type, parsed });

if (!success) {
return false;
}
Expand Down
Loading